New Adapter: BrightMountainMedia

adapters/bmtm/brightmountainmedia.go

@@ -50,14 +50,14 @@ func (a *adapter) makeRequest(ortbRequest openrtb2.BidRequest, ortbImp openrtb2.
 	var bidderExt adapters.ExtImpBidder
 	if err := json.Unmarshal(ortbImp.Ext, &bidderExt); err != nil {
 		return nil, &errortypes.BadInput{
-			Message: "Error unmarshalling ExtImpBidder",
+			Message: fmt.Sprintf("Error unmarshalling ExtImpBidder: %s", err.Error()),
 		}
 	}
 
 	var bmtmExt openrtb_ext.ImpExtBmtm
 	if err := json.Unmarshal(bidderExt.Bidder, &bmtmExt); err != nil {
 		return nil, &errortypes.BadInput{
-			Message: "Error unmarshalling ExtImpBmtm",
+			Message: fmt.Sprintf("Error unmarshalling ExtImpBmtm: %s", err.Error()),
 		}
 	}
 

adapters/bmtm/brightmountainmedia_test.go

@@ -1,19 +1,21 @@
 package bmtm
 
 import (
+	"fmt"
 	"testing"
 
 	"github.com/prebid/prebid-server/adapters/adapterstest"
 	"github.com/prebid/prebid-server/config"
 	"github.com/prebid/prebid-server/openrtb_ext"
+	"github.com/stretchr/testify/assert"
 )
 
 func TestJsonSamples(t *testing.T) {
 	bidder, buildErr := Builder(openrtb_ext.BidderBmtm, config.Adapter{
 		Endpoint: "https://example.com/api/pbs"})
 
 	if buildErr != nil {
-		t.Fatalf("Builder returned unexpected error %v", buildErr)
+		assert.NoError(t, buildErr, fmt.Sprintf("Builder returned unexpected error: %s", buildErr.Error()))
 	}
 
 	adapterstest.RunJSONBidderTest(t, "brightmountainmediatest", bidder)

adapters/bmtm/params_test.go

@@ -2,33 +2,35 @@ package bmtm
 
 import (
 	"encoding/json"
+	"fmt"
 	"testing"
 
 	"github.com/prebid/prebid-server/openrtb_ext"
+	"github.com/stretchr/testify/assert"
 )
 
 func TestValidParams(t *testing.T) {
 	validator, err := openrtb_ext.NewBidderParamsValidator("../../static/bidder-params")
 	if err != nil {
-		t.Fatalf("Failed to fetch the json-schemas. %v", err)
+		assert.NoError(t, err, fmt.Sprintf("Failed to fetch the json-schemas: %s", err.Error()))
 	}
 
 	for _, validParam := range validParams {
 		if err := validator.Validate(openrtb_ext.BidderBmtm, json.RawMessage(validParam)); err != nil {
-			t.Errorf("Schema rejected brightMountainMedia params: %s", validParam)
+			assert.NoError(t, err, fmt.Sprintf("Schema rejected brightMountainMedia params: %s", validParam))
 		}
 	}
 }
 
 func TestInvalidParams(t *testing.T) {
 	validator, err := openrtb_ext.NewBidderParamsValidator("../../static/bidder-params")
 	if err != nil {
-		t.Fatalf("Failed to fetch the json-schemas. %v", err)
+		assert.NoError(t, err, fmt.Sprintf("Failed to fetch the json-schemas: %s", err.Error()))
 	}
 
 	for _, invalidParam := range invalidParams {
 		if err := validator.Validate(openrtb_ext.BidderBmtm, json.RawMessage(invalidParam)); err == nil {
-			t.Errorf("Schema allowed unexpected params: %s", invalidParam)
+			assert.NoError(t, err, fmt.Sprintf("Schema allowed unexpected params: %s", invalidParam))
 		}
 	}
 }