Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/cookie_sync Endpoint Rewrite #1879

Merged
merged 65 commits into from
Aug 19, 2021
Merged
Show file tree
Hide file tree
Changes from 63 commits
Commits
Show all changes
65 commits
Select commit Hold shift + click to select a range
72be0a4
Implement New Bidder Chooser
SyntaxNode Apr 20, 2021
8dffdd1
Added User Sync Chooser + Test Cleanup
SyntaxNode Apr 22, 2021
9da6cd3
Remoe Unused customBidderTTLs
SyntaxNode Apr 22, 2021
5e3160b
Cookie Refactor
SyntaxNode Apr 22, 2021
0a0de85
Large Development Checkpoint
SyntaxNode May 28, 2021
c454f5a
Fixed Syncer Template Composition
SyntaxNode May 28, 2021
a934a7f
Finished TestComposeTemplate
SyntaxNode May 28, 2021
fe14358
Finish NewSyncer Tests + Refactor
SyntaxNode Jun 1, 2021
86a8635
Finished Syncers Builder + First Pass SetUID
prebid-jenkins Jun 4, 2021
258d1ca
Add SetUID Tests
prebid-jenkins Jun 4, 2021
f71c5d5
Add Proper Syncer Key Lookup In Exchange Logic
prebid-jenkins Jun 4, 2021
684d997
Initial Support For Config Overrides
prebid-jenkins Jun 4, 2021
c3217a7
Stuff I Missed From The Last Commit
prebid-jenkins Jun 4, 2021
021d57d
Fixed Metric Tests + Added Config Bindings
prebid-jenkins Jun 4, 2021
d2339cf
Biddeer Info Tweaks
prebid-jenkins Jun 5, 2021
fbc0709
Self Code Review Pass
SyntaxNode Jun 5, 2021
1b6ba8a
Merge branch 'master' into usersync_v2
SyntaxNode Jun 5, 2021
5d6d6bf
Remove Go 1.16 Specific Type
SyntaxNode Jun 5, 2021
23052a3
Don't Create Syncer If Disabled
SyntaxNode Jun 13, 2021
70fb2f8
Finish Config Integration
SyntaxNode Jun 13, 2021
556fcf0
Merge branch 'master' into usersync_v2
SyntaxNode Jun 13, 2021
bc31e6c
Fix Merge Conflicts
SyntaxNode Jun 13, 2021
68a2710
Implement Legacy UserSyncURL Overrides
SyntaxNode Jun 13, 2021
02cc6a7
Set UserSync Endpoints
SyntaxNode Jun 14, 2021
6f4950b
Bidder user sync configs
Jun 16, 2021
24d04f7
User Sync Metrics
SyntaxNode Jun 16, 2021
4cbde48
Merge branch 'master' into usersync_v2
SyntaxNode Jun 16, 2021
973cfb2
Code review fixes
Jul 1, 2021
5f74c4c
Merge pull request #2 from SyntaxNode/bidder_configs
SyntaxNode Jul 6, 2021
a031639
Redirect URL Comment / Warning
SyntaxNode Jul 6, 2021
22b1ce7
Merge branch 'master' into usersync_v2
SyntaxNode Jul 6, 2021
168c5b7
Merge missed files.
SyntaxNode Jul 6, 2021
b2406be
Merge branch 'usersync_v2' of github.com:SyntaxNode/prebid-server int…
SyntaxNode Jul 6, 2021
953b44c
Merge branch 'master' into usersync_v2
SyntaxNode Jul 7, 2021
63ca092
Remove TODO File
SyntaxNode Jul 7, 2021
5cb47e4
Fix Regex + Add Tests
SyntaxNode Jul 8, 2021
e0cfdd6
Merge branch 'master' into usersync_v2
SyntaxNode Jul 8, 2021
be5a4e8
Merge branch 'master' into usersync_v2
SyntaxNode Jul 14, 2021
41721e4
Merge branch 'master' into usersync_v2
SyntaxNode Aug 3, 2021
762cd31
Update Comments. Provide Legacy Config Warning.
SyntaxNode Aug 3, 2021
bfdb132
Add Suggested Test
SyntaxNode Aug 3, 2021
f32e60a
Merge branch 'master' into usersync_v2
SyntaxNode Aug 3, 2021
89e54bc
Separated BidderFilter
SyntaxNode Aug 4, 2021
08334e5
PR Feedback
SyntaxNode Aug 4, 2021
69ae29e
Merge branch 'master' into usersync_v2
SyntaxNode Aug 4, 2021
0e10d27
Tweak Handlng Of `f` Query Param
SyntaxNode Aug 5, 2021
83f0f48
Treat Macro-Like User Sync Config As Literals
SyntaxNode Aug 5, 2021
ed30a55
Fix User Sync CCPA Enforcement
SyntaxNode Aug 5, 2021
f9bf1c5
Fix SetUID Syncer Key Handling
SyntaxNode Aug 5, 2021
75231a1
Merge branch 'master' into usersync_v2
SyntaxNode Aug 5, 2021
4f9568a
Fix ExternalURL Override Hierarchy
SyntaxNode Aug 10, 2021
d6bb366
Reconciled + Verified User Sync Endpoints
SyntaxNode Aug 10, 2021
ebaa7e1
Improved Syncer Bidder Map Variable Name
SyntaxNode Aug 10, 2021
8b2c36d
Add Test Time Validation
SyntaxNode Aug 10, 2021
a16417a
Improved Error Message
SyntaxNode Aug 11, 2021
0a6655c
Fixed Test Descriptions
SyntaxNode Aug 11, 2021
1daa441
Merge branch 'master' into usersync_v2
SyntaxNode Aug 11, 2021
5649c77
Update InMobi Syncer
SyntaxNode Aug 11, 2021
7d3bbb5
Allow Bidders To Represent Support Without Default
SyntaxNode Aug 12, 2021
d7389d3
Revert "Allow Bidders To Represent Support Without Default"
SyntaxNode Aug 16, 2021
745eb3a
Improved Errors
SyntaxNode Aug 16, 2021
c12d936
User Sync Supports Field
SyntaxNode Aug 17, 2021
c5fb9b5
Emit Warning For Unconfigured Supported User Sync
SyntaxNode Aug 18, 2021
2cc6ec3
Fixed Test Typo
SyntaxNode Aug 18, 2021
18ea3ca
Merge branch 'master' into usersync_v2
SyntaxNode Aug 19, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
12 changes: 0 additions & 12 deletions adapters/33across/usersync.go

This file was deleted.

34 changes: 0 additions & 34 deletions adapters/33across/usersync_test.go

This file was deleted.

4 changes: 2 additions & 2 deletions adapters/acuityads/acuityads.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import (
)

type AcuityAdsAdapter struct {
endpoint template.Template
endpoint *template.Template
SyntaxNode marked this conversation as resolved.
Show resolved Hide resolved
}

// Builder builds a new instance of the AcuityAds adapter for the given bidder with the given config.
Expand All @@ -26,7 +26,7 @@ func Builder(bidderName openrtb_ext.BidderName, config config.Adapter) (adapters
}

bidder := &AcuityAdsAdapter{
endpoint: *template,
endpoint: template,
}
return bidder, nil
}
Expand Down
12 changes: 0 additions & 12 deletions adapters/acuityads/usersync.go

This file was deleted.

33 changes: 0 additions & 33 deletions adapters/acuityads/usersync_test.go

This file was deleted.

12 changes: 0 additions & 12 deletions adapters/adagio/usersync.go

This file was deleted.

34 changes: 0 additions & 34 deletions adapters/adagio/usersync_test.go

This file was deleted.

12 changes: 0 additions & 12 deletions adapters/adf/usersync.go

This file was deleted.

31 changes: 0 additions & 31 deletions adapters/adf/usersync_test.go

This file was deleted.

2 changes: 1 addition & 1 deletion adapters/adform/adform_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ func preparePrebidRequest(serverUrl string, t *testing.T) *pbs.PBSRequest {
prebidHttpRequest.Header.Add("Referer", adformTestData.referrer)
prebidHttpRequest.Header.Add("X-Real-IP", adformTestData.deviceIP)

pbsCookie := usersync.ParsePBSCookieFromRequest(prebidHttpRequest, &config.HostCookie{})
pbsCookie := usersync.ParseCookieFromRequest(prebidHttpRequest, &config.HostCookie{})
pbsCookie.TrySync("adform", adformTestData.buyerUID)
fakeWriter := httptest.NewRecorder()

Expand Down
12 changes: 0 additions & 12 deletions adapters/adform/usersync.go

This file was deleted.

31 changes: 0 additions & 31 deletions adapters/adform/usersync_test.go

This file was deleted.

4 changes: 2 additions & 2 deletions adapters/adhese/adhese.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import (
)

type AdheseAdapter struct {
endpointTemplate template.Template
endpointTemplate *template.Template
}

func extractSlotParameter(parameters openrtb_ext.ExtImpAdhese) string {
Expand Down Expand Up @@ -276,7 +276,7 @@ func Builder(bidderName openrtb_ext.BidderName, config config.Adapter) (adapters
}

bidder := &AdheseAdapter{
endpointTemplate: *template,
endpointTemplate: template,
}
return bidder, nil
}
4 changes: 2 additions & 2 deletions adapters/adkernel/adkernel.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import (
)

type adkernelAdapter struct {
EndpointTemplate template.Template
EndpointTemplate *template.Template
}

//MakeRequests prepares request information for prebid-server core
Expand Down Expand Up @@ -262,7 +262,7 @@ func Builder(bidderName openrtb_ext.BidderName, config config.Adapter) (adapters
}

bidder := &adkernelAdapter{
EndpointTemplate: *urlTemplate,
EndpointTemplate: urlTemplate,
}
return bidder, nil
}
12 changes: 0 additions & 12 deletions adapters/adkernel/usersync.go

This file was deleted.

34 changes: 0 additions & 34 deletions adapters/adkernel/usersync_test.go

This file was deleted.

4 changes: 2 additions & 2 deletions adapters/adkernelAdn/adkernelAdn.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import (
const defaultDomain string = "tag.adkernel.com"

type adkernelAdnAdapter struct {
EndpointTemplate template.Template
EndpointTemplate *template.Template
}

//MakeRequests prepares request information for prebid-server core
Expand Down Expand Up @@ -286,7 +286,7 @@ func Builder(bidderName openrtb_ext.BidderName, config config.Adapter) (adapters
}

bidder := &adkernelAdnAdapter{
EndpointTemplate: *template,
EndpointTemplate: template,
}
return bidder, nil
}
12 changes: 0 additions & 12 deletions adapters/adkernelAdn/usersync.go

This file was deleted.

Loading