Remove time.Now() as the first parameter of NewRates()

[guscarreon]

The DataAsOf time.Time field of the Rates struct found in currency/rates.go has no use in practice because (rc *RateConverter) update() method sets the RateConverter's lastUpdated field to time.Now() in line 82 shown below and ignores the rates.DataAsOf field that the fetch() function unmarshals in line 79. This pull request removes the DataAsOf field entirely which is useful in order to simplify the code specially in the numerous NewRates() calls throughout the codebase.

 77 // Update updates the internal currencies rates from remote sources
 78 func (rc *RateConverter) update() error {
 79     rates, err := rc.fetch()
 80     if err == nil {
 81         rc.rates.Store(rates)
 82         rc.lastUpdated.Store(rc.time.Now())
 83     } else {
 84         if rc.checkStaleRates() {
 85             rc.clearRates()
 86             glog.Errorf("Error updating conversion rates, falling back to constant rates: %v", err)
 87         } else {
 88             glog.Errorf("Error updating conversion rates: %v", err)
 89         }
 90     }
 91
 92     return err
 93 }
 94
 95 func (rc *RateConverter) Run() error {
 96     return rc.update()
 97 }
currency/rate_converter.go

[bsardo]

Looks good; just a nitpick.

[bsardo]

You should also be able to delete wantDataAsOf in the tests struct in this test TestReadWriteRates.

[guscarreon]

You're totally right. Removed

[bsardo]

LGTM