Vrtcal: Added Video(VAST) Support #1965
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,96 @@ | ||
| { | ||
| "mockBidRequest": { | ||
| "id": "test-request-id", | ||
| "imp": [ | ||
| { | ||
| "id": "test-imp-id", | ||
| "video": { | ||
| "mimes": ["video/mp4"], | ||
| "protocols": [2, 5], | ||
| "w": 300, | ||
| "h": 250 | ||
| }, | ||
| "ext": { | ||
| "bidder": { | ||
| "Just_an_unused_vrtcal_param": "unused_data_for_this" | ||
| } | ||
| } | ||
| } | ||
| ], | ||
| "app": { | ||
| "id": "fake-app-id" | ||
| } | ||
| }, | ||
| "httpCalls": [ | ||
| { | ||
| "expectedRequest": { | ||
| "uri": "http://rtb.vrtcal.com/bidder_prebid.vap?ssp=1804", | ||
| "body": { | ||
| "id": "test-request-id", | ||
| "imp": [ | ||
| { | ||
| "id": "test-imp-id", | ||
| "video": { | ||
| "mimes": ["video/mp4"], | ||
| "protocols": [2, 5], | ||
| "w": 300, | ||
| "h": 250 | ||
| }, | ||
|
|
||
| "ext": { | ||
| "bidder": { | ||
| "Just_an_unused_vrtcal_param": "unused_data_for_this" | ||
| } | ||
| } | ||
| } | ||
| ], | ||
| "app": { | ||
| "id": "fake-app-id" | ||
| } | ||
| } | ||
| }, | ||
| "mockResponse": { | ||
| "status": 200, | ||
| "body": { | ||
| "id": "test-request-id", | ||
| "seatbid": [ | ||
| { | ||
| "seat": "vrtcal", | ||
| "bid": [ | ||
| { | ||
| "id": "8ee514f1-b2b8-4abb-89fd-084437d1e800", | ||
| "impid": "test-imp-id", | ||
| "price": 0.500000, | ||
| "adm": "some-test-video-ad", | ||
| "crid": "crid_10", | ||
| "h": 250, | ||
| "w": 300 | ||
| } | ||
| ] | ||
| } | ||
| ], | ||
| "cur": "USD" | ||
| } | ||
| } | ||
| } | ||
| ], | ||
| "expectedBidResponses": [ | ||
| { | ||
| "currency": "USD", | ||
| "bids": [ | ||
| { | ||
| "bid": { | ||
| "id": "8ee514f1-b2b8-4abb-89fd-084437d1e800", | ||
| "impid": "test-imp-id", | ||
| "price": 0.5, | ||
| "adm": "some-test-video-ad", | ||
| "crid": "crid_10", | ||
| "w": 300, | ||
| "h": 250 | ||
| }, | ||
| "type": "video" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| { | ||
| "mockBidRequest": { | ||
| "id": "test-request-id", | ||
| "imp": [ | ||
| { | ||
| "id": "test-imp-id", | ||
| "banner": { | ||
| "format": [ | ||
| { | ||
| "w": 300, | ||
| "h": 250 | ||
| } | ||
| ] | ||
| }, | ||
| "ext": { | ||
| "bidder": { | ||
| "Just_an_unused_vrtcal_param": "unused_data_for_this" | ||
| } | ||
| } | ||
| } | ||
| ], | ||
| "app": { | ||
| "id": "fake-app-id" | ||
| } | ||
| }, | ||
| "httpCalls": [ | ||
| { | ||
| "expectedRequest": { | ||
| "uri": "http://rtb.vrtcal.com/bidder_prebid.vap?ssp=1804", | ||
| "body": { | ||
| "id": "test-request-id", | ||
| "imp": [ | ||
| { | ||
| "id": "test-imp-id", | ||
| "banner": { | ||
| "format": [ | ||
| { | ||
| "w": 300, | ||
| "h": 250 | ||
| } | ||
| ] | ||
| }, | ||
|
|
||
| "ext": { | ||
| "bidder": { | ||
| "Just_an_unused_vrtcal_param": "unused_data_for_this" | ||
| } | ||
| } | ||
| } | ||
| ], | ||
| "app": { | ||
| "id": "fake-app-id" | ||
| } | ||
| } | ||
| }, | ||
| "mockResponse": { | ||
| "status": 200, | ||
| "body": { | ||
| "id": "test-request-id", | ||
| "seatbid": [ | ||
| { | ||
| "seat": "vrtcal", | ||
| "bid": [ | ||
| { | ||
| "id": "8ee514f1-b2b8-4abb-89fd-084437d1e800", | ||
| "impid": "WRONG-IMPRESSION_ID", | ||
| "price": 0.500000, | ||
| "adm": "some-test-ad", | ||
| "crid": "crid_10", | ||
| "h": 250, | ||
| "w": 300 | ||
| } | ||
| ] | ||
| } | ||
| ], | ||
| "cur": "USD" | ||
| } | ||
| } | ||
| } | ||
| ], | ||
| "expectedMakeBidsErrors": [ | ||
| { | ||
| "value": "Failed to find impression for ID: \"WRONG-IMPRESSION_ID\"", | ||
| "comparison": "literal" | ||
| } | ||
| ] | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,3 +4,4 @@ capabilities: | |
| app: | ||
| mediaTypes: | ||
| - banner | ||
| - video | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I missed this in my earlier review. In case there's an error getting the type of one of the bids, are you sure you want to return an error and discard the rest of the bids? It might be better to rather append the error in an error slice and move on to the next bid by adding a
continuehere.Thinking more about this, I realize that you mentioned your backend service only bids on a single impression for a single request so the response likely is gonna have a single bid as well but I'd still recommend adding a
continuehere and appending the error to an error slice as it is easy to do and this way you won't have to update this logic in the future even when your backend service does start supporting multiple impressions and returning multiple bidsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Mansinahar. I've added a patch to allow the continuance of processing of further bids after ones with an unmatched Impression ID...