New Adapter: RichAudience #2001

richaudience · 2021-09-16T11:55:36Z

New Adapter: RichAudience

adapters/richaudience/richaudience.go

config/config.go

exchange/adapter_builders.go

static/bidder-info/richaudience.yaml

openrtb_ext/imp_richaudience.go

VeronikaSolovei9

@richaudience Thank you for addressing my comments, I appreciate you cooperation and patience. I re-reviewed updates and added some more comments.

adapters/richaudience/richaudience.go

VeronikaSolovei9 · 2021-09-23T03:33:29Z

May I ask you to add a test where there are 2 or more imps in request?

AlexBVolcy

I noticed you didn't comment a link to your docs PR? Do you mind posting a link to that and if you don't have a docs PR could you make one? Thanks!

adapters/richaudience/richaudience.go

richaudience · 2021-09-29T07:50:41Z

Hi Alex,

I send the pull request where you will see the documentation

prebid/prebid.github.io#3302

SyntaxNode

I appreciate the extensive test coverage. The coded tests other than TestJsonSamples and TestGetBuilder are not necessary in our opinion. For code coverage, we only consider the json tests since we have extra protection and tests built into that framework. I consider TestResponseOK particularly overkill, as one of the reasons we built the json test framework is to avoid this situation of walls of json hardcoded as strings in test code.

adapters/richaudience/richaudience.go

adapters/richaudience/params_test.go

adapters/richaudience/richaudience.go

static/bidder-info/richaudience.yaml

SyntaxNode · 2021-09-29T16:48:11Z

static/bidder-info/richaudience.yaml

+      - banner
+userSync:
+  iframe:
+    url: "https://sync.richaudience.com/74889303289e27f327ad0c6de7be7264/?consentString={{.GDPRConsent}}&r={{.RedirectURL}}[PDID]"


What is the purpose of [PDID] at the end of the url? This looks like it will cause the redirect url to be incorrectly formed.

in next commit i have solved

For us this macro is correct, i will not change this

This is not the correct way to specify the macro. It only works due to coincidental positioning of the fields of the default redirect url template . Please see: https://docs.prebid.org/prebid-server/developers/add-new-bidder-go.html#bidder-info

Please remove [PDID] from the url and add it as a userMacro config:

url: "https://sync.richaudience.com/74889303289e27f327ad0c6de7be7264/?consentString={{.GDPRConsent}}&r={{.RedirectURL}}" userMacro: "[PDID]"

static/bidder-params/richaudience.json

richaudience · 2021-09-30T14:31:26Z

Hi

Thanks for your comments, I have push a new commit to apply the recommended changes

Cheers

richaudience · 2021-10-05T06:18:09Z

Can you tell me why the compilation is failing in this point? In my tests it does not fail.
TestTrimCookiesClosestExpirationDates

SyntaxNode · 2021-10-05T17:54:44Z

Can you tell me why the compilation is failing in this point? In my tests it does not fail. TestTrimCookiesClosestExpirationDates

That's a flaky test not related to your code. Don't worry about it.

openrtb_ext/imp_richaudience.go

adapters/richaudience/richaudiencetest/params/race/banner.json

adapters/richaudience/richaudience.go

VeronikaSolovei9 · 2021-10-07T07:57:59Z

In documentation here https://github.com/prebid/prebid.github.io/blob/master/dev-docs/bidders/richaudience.md you mentioned: supported media types: banner and video. In code I can only see support for banner. Please update documentation to avoid ambiguity.
Also from previous discussion: #2001 (comment)

adapters/richaudience/richaudience.go

exchange/adapter_builders.go

adapters/richaudience/richaudience.go

richaudience · 2021-10-07T13:47:42Z

In documentation here https://github.com/prebid/prebid.github.io/blob/master/dev-docs/bidders/richaudience.md you mentioned: supported media types: banner and video. In code I can only see support for banner. Please update documentation to avoid ambiguity. Also from previous discussion: #2001 (comment)

We are not video compatible for prebid server, but we will be soon. There is no need to generate confusion in the documentation.
Thank you for your recommendation.

Cheers

guscarreon

LGTM. Thank you for addressing the comments

adapters/richaudience/richaudience.go

adapters/richaudience/richaudience_test.go

SyntaxNode · 2021-10-11T16:45:06Z

static/bidder-info/richaudience.yaml

+      - banner
+userSync:
+  iframe:
+    url: "https://sync.richaudience.com/74889303289e27f327ad0c6de7be7264/?consentString={{.GDPRConsent}}&r={{.RedirectURL}}[PDID]"


This is not the correct way to specify the macro. It only works due to coincidental positioning of the fields of the default redirect url template . Please see: https://docs.prebid.org/prebid-server/developers/add-new-bidder-go.html#bidder-info

Please remove [PDID] from the url and add it as a userMacro config:

url: "https://sync.richaudience.com/74889303289e27f327ad0c6de7be7264/?consentString={{.GDPRConsent}}&r={{.RedirectURL}}" userMacro: "[PDID]"

static/bidder-info/richaudience.yaml

richaudience · 2021-10-14T10:09:07Z

everything is ok, what is missing so that you can upload the adapter?

SyntaxNode · 2021-10-14T21:14:38Z

The changes look good.

Please revisit my comments on the request data structure. You also need to fix the user macro configuration of the user sync in the bidder yaml file.

richaudience · 2021-10-18T14:34:18Z

Hi,

I have modified the two requests you had, please check the code.

Cheer

adapters/richaudience/richaudience.go

SyntaxNode

Thank you for your updates. The json test coverage looks good as does the code updates. I left a few nitpicks for misleading function names and a behavior change request for bid floor currency handling. The rest looks good to me.

adapters/richaudience/richaudience.go

richaudience · 2021-10-20T13:38:35Z

I have applied the latest changes, please check.

SyntaxNode

Excellent. Thank you. The code looks good to me now. I have a few final comments after closely reviewing the tests.

adapters/richaudience/richaudience.go

adapters/richaudience/richaudiencetest/exemplary/single-banner-app.json

adapters/richaudience/richaudiencetest/exemplary/single-banner-deviceConfig.json

adapters/richaudience/richaudiencetest/exemplary/single-banner-extUser.json

adapters/richaudience/richaudiencetest/exemplary/single-banner-floorPrice.json

adapters/richaudience/richaudiencetest/exemplary/single-banner-nosecure.json

adapters/richaudience/richaudiencetest/exemplary/single-banner-sitePage.json

adapters/richaudience/richaudiencetest/supplemental/pidNotORTB.json

adapters/richaudience/richaudiencetest/supplemental/requestWrongRequest.json

guscarreon

LGTM

Co-authored-by: sgimenez <sergi.gimenez@richaudience.com>

richaudience added 3 commits September 16, 2021 13:26

Initial commit

865fa84

Add Richaudience Adapter

1fe7df2

Change endpoint

a2c2918

mansinahar requested review from AlexBVolcy, guscarreon and VeronikaSolovei9 September 16, 2021 17:35

mansinahar assigned VeronikaSolovei9, guscarreon and AlexBVolcy Sep 16, 2021

VeronikaSolovei9 reviewed Sep 17, 2021

View reviewed changes

Changes for pull request

248f03d

VeronikaSolovei9 reviewed Sep 23, 2021

View reviewed changes

changes to correct issues

1ad738f

AlexBVolcy reviewed Sep 28, 2021

View reviewed changes

AlexBVolcy reviewed Sep 29, 2021

View reviewed changes

adapters/richaudience/richaudience.go Outdated Show resolved Hide resolved

richaudience added 2 commits September 29, 2021 10:22

Change name adapter and add the doc

1de17ad

Add Test

c1d3255

SyntaxNode reviewed Sep 29, 2021

View reviewed changes

Push new Changes

a838f27

richaudience added 2 commits September 30, 2021 17:02

Push

a92ed9f

code coverage

62c039d

guscarreon reviewed Oct 7, 2021

View reviewed changes

VeronikaSolovei9 reviewed Oct 7, 2021

View reviewed changes

adapters/richaudience/richaudience.go Outdated Show resolved Hide resolved

VeronikaSolovei9 reviewed Oct 7, 2021

View reviewed changes

adapters/richaudience/richaudience.go Show resolved Hide resolved

VeronikaSolovei9 reviewed Oct 7, 2021

View reviewed changes

adapters/richaudience/richaudience.go Show resolved Hide resolved

VeronikaSolovei9 reviewed Oct 7, 2021

View reviewed changes

exchange/adapter_builders.go Outdated Show resolved Hide resolved

VeronikaSolovei9 reviewed Oct 7, 2021

View reviewed changes

adapters/richaudience/richaudience.go Show resolved Hide resolved

Coverage > 95%

86ef75f

guscarreon previously approved these changes Oct 8, 2021

View reviewed changes

SyntaxNode reviewed Oct 11, 2021

View reviewed changes

New changes

e961b4c

richaudience dismissed guscarreon’s stale review via e961b4c October 14, 2021 10:11

Remove data struct & Change macro Sync

dc70194

VeronikaSolovei9 reviewed Oct 19, 2021

View reviewed changes

adapters/richaudience/richaudience.go Outdated Show resolved Hide resolved

VeronikaSolovei9 previously approved these changes Oct 19, 2021

View reviewed changes

Remove requestInfo in setUser

80ebb94

richaudience dismissed VeronikaSolovei9’s stale review via 80ebb94 October 19, 2021 07:31

VeronikaSolovei9 previously approved these changes Oct 19, 2021

View reviewed changes

SyntaxNode reviewed Oct 19, 2021

View reviewed changes

adapters/richaudience/richaudience.go Outdated Show resolved Hide resolved

adapters/richaudience/richaudience.go Outdated Show resolved Hide resolved

adapters/richaudience/richaudience.go Outdated Show resolved Hide resolved

adapters/richaudience/richaudience.go Show resolved Hide resolved

Changes name of functions

3ce3193

richaudience dismissed VeronikaSolovei9’s stale review via 3ce3193 October 20, 2021 13:39

SyntaxNode reviewed Oct 20, 2021

View reviewed changes

Changes JSON Test

0a184fa

guscarreon approved these changes Oct 22, 2021

View reviewed changes

SyntaxNode approved these changes Oct 22, 2021

View reviewed changes

SyntaxNode merged commit d7d4b8b into prebid:master Oct 22, 2021

mansinahar pushed a commit to mansinahar/prebid-server that referenced this pull request Jan 18, 2022

New Adapter: RichAudience (prebid#2001)

250db4d

Co-authored-by: sgimenez <sergi.gimenez@richaudience.com>

jorgeluisrocha pushed a commit to jwplayer/prebid-server that referenced this pull request Sep 28, 2022

New Adapter: RichAudience (prebid#2001)

0621a8a

Co-authored-by: sgimenez <sergi.gimenez@richaudience.com>

shunj-nb pushed a commit to ParticleMedia/prebid-server that referenced this pull request Nov 8, 2022

New Adapter: RichAudience (prebid#2001)

731894e

Co-authored-by: sgimenez <sergi.gimenez@richaudience.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Adapter: RichAudience #2001

New Adapter: RichAudience #2001

richaudience commented Sep 16, 2021

VeronikaSolovei9 left a comment

VeronikaSolovei9 commented Sep 23, 2021

AlexBVolcy left a comment

richaudience commented Sep 29, 2021

SyntaxNode left a comment

SyntaxNode Sep 29, 2021

richaudience Sep 30, 2021

SyntaxNode Oct 11, 2021

richaudience commented Sep 30, 2021

richaudience commented Oct 5, 2021

SyntaxNode commented Oct 5, 2021

VeronikaSolovei9 commented Oct 7, 2021

richaudience commented Oct 7, 2021

guscarreon left a comment

SyntaxNode Oct 11, 2021

richaudience commented Oct 14, 2021

SyntaxNode commented Oct 14, 2021

richaudience commented Oct 18, 2021

SyntaxNode left a comment

richaudience commented Oct 20, 2021

SyntaxNode left a comment

guscarreon left a comment

New Adapter: RichAudience #2001

New Adapter: RichAudience #2001

Conversation

richaudience commented Sep 16, 2021

VeronikaSolovei9 left a comment

Choose a reason for hiding this comment

VeronikaSolovei9 commented Sep 23, 2021

AlexBVolcy left a comment

Choose a reason for hiding this comment

richaudience commented Sep 29, 2021

SyntaxNode left a comment

Choose a reason for hiding this comment

SyntaxNode Sep 29, 2021

Choose a reason for hiding this comment

richaudience Sep 30, 2021

Choose a reason for hiding this comment

SyntaxNode Oct 11, 2021

Choose a reason for hiding this comment

richaudience commented Sep 30, 2021

richaudience commented Oct 5, 2021

SyntaxNode commented Oct 5, 2021

VeronikaSolovei9 commented Oct 7, 2021

richaudience commented Oct 7, 2021

guscarreon left a comment

Choose a reason for hiding this comment

SyntaxNode Oct 11, 2021

Choose a reason for hiding this comment

richaudience commented Oct 14, 2021

SyntaxNode commented Oct 14, 2021

richaudience commented Oct 18, 2021

SyntaxNode left a comment

Choose a reason for hiding this comment

richaudience commented Oct 20, 2021

SyntaxNode left a comment

Choose a reason for hiding this comment

guscarreon left a comment

Choose a reason for hiding this comment