Add account-specific error metrics to setuid endpoint #2337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsardo
commented
Aug 3, 2022
Comment on lines
+90
to
+92
| case errCookieSyncAccountBlocked: | ||
| metricsEngine.RecordSetUid(metrics.SetUidAccountBlocked) | ||
| case errCookieSyncAccountInvalid: |
There was a problem hiding this comment.
I figured it was ok to use the cookie sync errCookieSyncAccountBlocked and errCookieSyncAccountInvalid errors here since setuid is related to cookie sync instead of refactoring combineErrors or creating a similar function for use by setuid.
mansinahar
approved these changes
Aug 9, 2022
AlexBVolcy
approved these changes
Aug 10, 2022
wwwyyy
pushed a commit
to wwwyyy/prebid-server
that referenced
this pull request
Aug 12, 2022
* 'master' of https://github.com/wwwyyy/prebid-server: Add account-specific error metrics to setuid endpoint (prebid#2337) Add iframe usersync support for ix (prebid#2328) Ext Fields Exposed to Bidders (prebid#2331) Add redirect sync to richaudienceAdapter (prebid#2343)
pm-aadit-patil
pushed a commit
to PubMatic-OpenWrap/prebid-server
that referenced
this pull request
Sep 22, 2022
pm-aadit-patil
pushed a commit
to PubMatic-OpenWrap/prebid-server
that referenced
this pull request
Sep 22, 2022
pm-aadit-patil
pushed a commit
to PubMatic-OpenWrap/prebid-server
that referenced
this pull request
Sep 22, 2022
jorgeluisrocha
pushed a commit
to jwplayer/prebid-server
that referenced
this pull request
Sep 28, 2022
shunj-nb
pushed a commit
to ParticleMedia/prebid-server
that referenced
this pull request
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the setuid endpoint consistent with the cookie sync endpoint in how it reports account-related error metrics. Instead of always reporting "bad request" when there is an account error, we now indicate whether the account was blocked, or invalid before defaulting to "bad request".
Also a few changes were made to ensure any errors encountered by the setuid endpoint are appropriately logged when calling the analytic adapter
LogSetUIDObjectfunction.