Use bidder name instead of syncer key #2948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SyntaxNode
reviewed
Jul 19, 2023
| syncersByKey := make(map[string]usersync.Syncer, len(syncersByBidder)) | ||
| for _, v := range syncersByBidder { | ||
| syncersByKey[v.Key()] = v | ||
| } |
There was a problem hiding this comment.
The assumption is still generally true, but the bidder name is now important for activity control so this approach is no longer valid.
AlexBVolcy
reviewed
Jul 20, 2023
endpoints/setuid.go
Outdated
| key := query.Get("bidder") | ||
|
|
||
| if key == "" { | ||
| return nil, errors.New(`"bidder" query param is required`) | ||
| } | ||
|
|
||
| syncer, syncerExists := syncersByKey[key] | ||
| syncer, syncerExists := syncersByBidder[key] |
There was a problem hiding this comment.
Should key within the brackets [key] now be called bidder?
There was a problem hiding this comment.
Yes, this change is already present in this PR: #2897 (comment)
But yes, it will be simpler to have it here :)
SyntaxNode
reviewed
Jul 24, 2023
VeronikaSolovei9
dismissed stale reviews from AlexBVolcy and hhhjort
via
c6a9bd5
SyntaxNode
reviewed
Jul 25, 2023
SyntaxNode
approved these changes
Jul 25, 2023
AlexBVolcy
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redirect urls for bidders user sync now have
bidder={bidderName}notbidder={syncerKey}.user_syncendpoint now returns urls with redirect urls with bidder name instead of syncer key.setuidendpoint now accepts bidder name, not syncer key:setuid?bidder=appnexusnotsetuid?bidder=adnxsgetuidsendpoint returns ids by syncer key.