Adapter alias: syncer related changes #3075
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor to avoid usage of additional map and loop
onkarvhanumante
force-pushed
the
adapter-alias/syncer-related-change
branch
2 times, most recently
from
890101d to
7078ba5
Compare
getSyncerKey will help to decide syncer key for an alias or non-alias bidder
Code block also uses cfg for syncer config. So to avoid confusion between syncer and bidder info, rename cfg to bidderInfo
As per adapter alias feature, if alias doesn't define syncher config in YAML then alias will inherit syncher config of its parent bider. This includes inheriting syncer urls, keys etc. As of now, PBS has logic that prevents bidders from using same syncer key. But this logic doesn't check if bidders using same key have parent alias relationship. Due to this, validation fails for alias which inherits syncer config from parent. To fix this, commit makes changes to allow use of same syncer key for alias and parent bidder.
… its parent
An alias can define its syncer key in YAML configuration, but this key must not be the same as that of a bidder other than its parent
For example,
parent1:
syncer:
key: k1
alias1:
aliasOf: parent1
syncer:
Key: k1
parent2:
syncer:
key: k2
alias2:
aliasOf: parent2
syncer:
key: k1 // syncer key k1 conflicts with parent1 key
onkarvhanumante
force-pushed
the
adapter-alias/syncer-related-change
branch
from
7078ba5 to
660f505
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per adapter alias feature, if alias doesn't define syncher config in YAML then alias will inherit syncher config of its parent bider. This includes inheriting syncer urls, keys etc.
As of now, PBS has logic that prevents bidders from using same syncer key. But this logic doesn't check if bidders using same key have parent alias relationship among them. Due to this, validation fails for alias which inherits syncer config from parent. To address this issue, pull request introduces changes to allow the use of the same syncer key for aliases and their parent bidders.
Also, an alias can define its syncer key in YAML configuration, but this key must not be the same as that of a bidder other than its parent. For this, pull introduces to catcg alias whose syncher key conflicts with bidder other than its parent