New Adapter mabidder #3080

ecdrsvc · 2023-09-06T20:34:56Z

We have an existing Prebid.js adapter and would like to add this new Prebid Server adapter.

ecdrsvc · 2023-09-06T20:38:08Z

Documentation PR: prebid/prebid.github.io#4848

onkarvhanumante · 2023-09-07T10:46:34Z

@ecdrsvc feature branch ecdrsvc:master is 22 commits ahead of, 204 commits behind

should sync feature master with latest prebid:master updates.

github-actions · 2023-09-07T18:13:42Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 183345e

mabidder

Refer here for heat map coverage report

github.com/prebid/prebid-server/adapters/mabidder/mabidder.go:44:	Builder		100.0%
github.com/prebid/prebid-server/adapters/mabidder/mabidder.go:51:	MakeRequests	80.0%
github.com/prebid/prebid-server/adapters/mabidder/mabidder.go:66:	MakeBids	94.4%
total:									(statements)	92.0%

ecdrsvc · 2023-09-07T18:16:13Z

@onkarvhanumante, it's synced.

onkarvhanumante · 2023-09-08T09:52:01Z

adapters/mabidder/mabidder_test.go

+		Endpoint: "https://mabidder-test"},
+		config.Server{ExternalUrl: "http://hosturl.com", GvlID: 1, DataCenter: "2"})


should use https://prebid.ecdrsvc.com/pbs url as mentioned in bidder-info param

prebid-server/static/bidder-info/mabidder.yaml

Line 1 in 183345e

endpoint: "https://prebid.ecdrsvc.com/pbs"

onkarvhanumante · 2023-09-08T09:56:00Z

adapters/mabidder/mabidder.go

+	if responseData.StatusCode == http.StatusNoContent {
+		return nil, nil
+	}
+
+	if responseData.StatusCode == http.StatusBadRequest {
+		err := &errortypes.BadInput{
+			Message: fmt.Sprintf("Unexpected status code: %d. Bad request from publisher.", responseData.StatusCode),
+		}
+		return nil, []error{err}
+	}
+
+	if responseData.StatusCode != http.StatusOK {
+		err := &errortypes.BadServerResponse{
+			Message: fmt.Sprintf("Unexpected status code: %d.", responseData.StatusCode),
+		}
+		return nil, []error{err}
+	}
+


just a suggestion, could make use of utils mentioned below

prebid-server/adapters/response.go

Lines 9 to 26 in 0615109

func CheckResponseStatusCodeForErrors(response *ResponseData) error {

if response.StatusCode == http.StatusBadRequest {

return &errortypes.BadInput{

Message: fmt.Sprintf("Unexpected status code: %d. Run with request.debug = 1 for more info", response.StatusCode),

}

}

if response.StatusCode != http.StatusOK {

return fmt.Errorf("Unexpected status code: %d. Run with request.debug = 1 for more info", response.StatusCode)

}

return nil

}

func IsResponseStatusCodeNoContent(response *ResponseData) bool {

return response.StatusCode == http.StatusNoContent

}

onkarvhanumante · 2023-09-08T09:59:28Z

adapters/mabidder/mabidder.go

+type maServerResponse struct {
+	Responses       []maBidResponse
+	PrivateIdStatus string `json:"-"`
+}
+
+type maBidResponse struct {
+	RequestID         string  `json:"requestId"`
+	Currency          string  `json:"currency"`
+	Width             int32   `json:"width"`
+	Height            int32   `json:"height"`
+	PlacementId       string  `json:"creativeId"`
+	Deal              string  `json:"dealId,omitempty"`
+	NetRevenue        bool    `json:"netRevenue"`
+	TimeToLiveSeconds int32   `json:"ttl"`
+	AdTag             string  `json:"ad"`
+	MediaType         string  `json:"mediaType"`
+	Meta              maMeta  `json:"meta"`
+	CPM               float32 `json:"cpm"`
+}
+
+type maMeta struct {
+	AdDomain []string `json:"advertiserDomains"`
+}
+


scope of these struct is within mabidder package. so could ma prefix from above structs

- type maServerResponse struct { + type serverResponse struct { - type maBidResponse struct { + type bidResponse struct { - type maMeta struct { + type meta struct {

onkarvhanumante · 2023-09-08T10:09:45Z

adapters/mabidder/mabidder.go

+		if bidResponse.Currency == "" {
+			bidResponse.Currency = maBidResp.Currency
+		}


bidResponse is initialized by NewBidderResponseWithBidsCapacity() on line 90

prebid-server/adapters/bidder.go

Lines 72 to 78 in 8ffa1c6

// By default, currency is USD but this behavior might be subject to change.

func NewBidderResponseWithBidsCapacity(bidsCapacity int) *BidderResponse {

return &BidderResponse{

Currency: "USD",

Bids: make([]*TypedBid, 0, bidsCapacity),

}

}

Based on code setup, bidResponse.Currency will always be USD. Therefore, if check on line 107 will always be false and maBidResp.Currency won't be used. Perhaps you would like to make following change.

if maBidResp.Currency != "" { bidResponse.Currency = maBidResp.Currency }

onkarvhanumante · 2023-09-08T10:13:05Z

static/bidder-info/mabidder.yaml

@@ -0,0 +1,11 @@
+endpoint: "https://prebid.ecdrsvc.com/pbs"


endpoint is reachable

onkarvhanumante · 2023-09-08T10:20:31Z

static/bidder-info/mabidder.yaml

@@ -0,0 +1,11 @@
+endpoint: "https://prebid.ecdrsvc.com/pbs"
+maintainer:
+  email: lmprebidadapter@loblaw.ca


@ecdrsvc , PBS team attempted to verify above maintainer email. However was not able to reach you out on above specified email address.

Note that an working maintainer email is needed to proceed with this PR

sent an email again. Please reply with "received"

gargcreation1992

g2g after addressing Onkar's comment.

github-actions · 2023-09-08T19:36:07Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, f12bd30

mabidder

Refer here for heat map coverage report

github.com/prebid/prebid-server/adapters/mabidder/mabidder.go:41:	Builder		100.0%
github.com/prebid/prebid-server/adapters/mabidder/mabidder.go:48:	MakeRequests	80.0%
github.com/prebid/prebid-server/adapters/mabidder/mabidder.go:63:	MakeBids	100.0%
total:									(statements)	95.2%

ecdrsvc · 2023-09-08T19:39:48Z

@onkarvhanumante the code has been updated with all your suggestions.
Regarding the email, there seems to be an issue with it. I'm waiting to hear back from our ops team and will update here when it's resolved.

gargcreation1992

g2g after email verification.

onkarvhanumante · 2023-09-12T12:54:41Z

@onkarvhanumante the code has been updated with all your suggestions. Regarding the email, there seems to be an issue with it. I'm waiting to hear back from our ops team and will update here when it's resolved.

adding block label on PR until we get update on working email

ecdrsvc · 2023-09-13T17:46:33Z

@onkarvhanumante the code has been updated with all your suggestions. Regarding the email, there seems to be an issue with it. I'm waiting to hear back from our ops team and will update here when it's resolved.

adding block label on PR until we get update on working email

The email issue has been fixed. Please send a verification message and we will reply. Thanks.

onkarvhanumante · 2023-09-14T07:27:55Z

@onkarvhanumante the code has been updated with all your suggestions. Regarding the email, there seems to be an issue with it. I'm waiting to hear back from our ops team and will update here when it's resolved.

adding block label on PR until we get update on working email

The email issue has been fixed. Please send a verification message and we will reply. Thanks.

Verification email is being sent to lmprebidadapter@loblaw.ca. Waiting for reply

gargcreation1992

g2g after email verification.

ecdrsvc · 2023-09-14T13:47:11Z

Just confirming here that we got the verification email and replied with 'received'. Let me know if any issues.

onkarvhanumante · 2023-09-14T14:32:39Z

Just confirming here that we got the verification email and replied with 'received'. Let me know if any issues.

received reply from mabidder

ecdrsvc added 22 commits April 24, 2023 14:37

add bidder configuration

5eb0681

add bidder parameter schema

29d8eeb

add bidder params struct implementation

a71055c

add mabidder adapter

e6bdbef

update bidders.go with mabidder

338d050

update adapter_builders with mabidder

69d6d94

simplify range

49ee6dc

update package

e6608ae

add mabidder_test.go

e318987

add server response types and implement MakeBids method

741fef3

update endpoint

f06e767

validate impression currency and process ext

d27411e

read bid/media type and ad domain from response

5737976

remove unnecessary validation

5616e13

fix bug with setting bidResponse currency in MakeBids method

e1d7d4c

update fake test endpoint

a48b8f5

params test

42c6663

don't hardcode status code in message

0200948

unit tests

49f0177

simplify error return in MakeReqeuests

d1a34ab

fix simple banner test case

d39ffe9

add supplemental test cases

b4ba52f

ecdrsvc mentioned this pull request Sep 6, 2023

update mabidder.md documetation support pbs prebid/prebid.github.io#4848

Merged

2 tasks

gargcreation1992 assigned gargcreation1992 and onkarvhanumante Sep 7, 2023

merge, add BidderMabidder

183345e

onkarvhanumante reviewed Sep 8, 2023

View reviewed changes

static/bidder-info/mabidder.yaml

@@ -0,0 +1,11 @@

endpoint: "https://prebid.ecdrsvc.com/pbs"

Copy link

Contributor

onkarvhanumante Sep 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

endpoint is reachable

onkarvhanumante reviewed Sep 8, 2023

View reviewed changes

gargcreation1992 reviewed Sep 8, 2023

View reviewed changes

ecdrsvc added 4 commits September 8, 2023 11:07

update uri in tests

be743b9

use util function for status error check

06a1267

rename internal structs used by mabidder

9d7c529

fix setting currency

f12bd30

gargcreation1992 approved these changes Sep 11, 2023

View reviewed changes

onkarvhanumante added the blocked label Sep 12, 2023

gargcreation1992 approved these changes Sep 14, 2023

View reviewed changes

onkarvhanumante approved these changes Sep 14, 2023

View reviewed changes

onkarvhanumante removed the blocked label Sep 14, 2023

gargcreation1992 merged commit e8632b0 into prebid:master Sep 15, 2023
5 checks passed

cross-repo-issue-creation bot mentioned this pull request Sep 15, 2023

Port PR from PBS-Go: New Adapter mabidder prebid/prebid-server-java#2632

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Adapter mabidder #3080

New Adapter mabidder #3080

ecdrsvc commented Sep 6, 2023

ecdrsvc commented Sep 6, 2023

onkarvhanumante commented Sep 7, 2023

github-actions bot commented Sep 7, 2023

ecdrsvc commented Sep 7, 2023

onkarvhanumante Sep 8, 2023

onkarvhanumante Sep 8, 2023

onkarvhanumante Sep 8, 2023

onkarvhanumante Sep 8, 2023 •

edited

Loading

onkarvhanumante Sep 8, 2023

onkarvhanumante Sep 8, 2023 •

edited

Loading

gargcreation1992 Sep 14, 2023

gargcreation1992 left a comment

github-actions bot commented Sep 8, 2023

ecdrsvc commented Sep 8, 2023

gargcreation1992 left a comment

onkarvhanumante commented Sep 12, 2023

ecdrsvc commented Sep 13, 2023

onkarvhanumante commented Sep 14, 2023

gargcreation1992 left a comment

ecdrsvc commented Sep 14, 2023

onkarvhanumante commented Sep 14, 2023

		Endpoint: "https://mabidder-test"},
		config.Server{ExternalUrl: "http://hosturl.com", GvlID: 1, DataCenter: "2"})


	func CheckResponseStatusCodeForErrors(response *ResponseData) error {
	if response.StatusCode == http.StatusBadRequest {
	return &errortypes.BadInput{
	Message: fmt.Sprintf("Unexpected status code: %d. Run with request.debug = 1 for more info", response.StatusCode),
	}
	}

	if response.StatusCode != http.StatusOK {
	return fmt.Errorf("Unexpected status code: %d. Run with request.debug = 1 for more info", response.StatusCode)
	}

	return nil
	}

	func IsResponseStatusCodeNoContent(response *ResponseData) bool {
	return response.StatusCode == http.StatusNoContent
	}

	// By default, currency is USD but this behavior might be subject to change.
	func NewBidderResponseWithBidsCapacity(bidsCapacity int) *BidderResponse {
	return &BidderResponse{
	Currency: "USD",
	Bids: make([]*TypedBid, 0, bidsCapacity),
	}
	}

New Adapter mabidder #3080

New Adapter mabidder #3080

Conversation

ecdrsvc commented Sep 6, 2023

ecdrsvc commented Sep 6, 2023

onkarvhanumante commented Sep 7, 2023

github-actions bot commented Sep 7, 2023

Code coverage summary

mabidder

ecdrsvc commented Sep 7, 2023

onkarvhanumante Sep 8, 2023

Choose a reason for hiding this comment

onkarvhanumante Sep 8, 2023

Choose a reason for hiding this comment

onkarvhanumante Sep 8, 2023

Choose a reason for hiding this comment

onkarvhanumante Sep 8, 2023 • edited Loading

Choose a reason for hiding this comment

onkarvhanumante Sep 8, 2023

Choose a reason for hiding this comment

onkarvhanumante Sep 8, 2023 • edited Loading

Choose a reason for hiding this comment

gargcreation1992 Sep 14, 2023

Choose a reason for hiding this comment

gargcreation1992 left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 8, 2023

Code coverage summary

mabidder

ecdrsvc commented Sep 8, 2023

gargcreation1992 left a comment

Choose a reason for hiding this comment

onkarvhanumante commented Sep 12, 2023

ecdrsvc commented Sep 13, 2023

onkarvhanumante commented Sep 14, 2023

gargcreation1992 left a comment

Choose a reason for hiding this comment

ecdrsvc commented Sep 14, 2023

onkarvhanumante commented Sep 14, 2023

onkarvhanumante Sep 8, 2023 •

edited

Loading

onkarvhanumante Sep 8, 2023 •

edited

Loading