record tmax timeout error in adapter error metric #3104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a bidderRequest loop [1], which goes through each bidder request. Inside this loop, PBS sends a request to the bidder server and handles the bidder's response or any errors that may occur. Within this loop, we gather all errors related to bidders using errorsToMetric() [2] and then record these errors into AdapterError metric using RecordAdapterRequest()[3] Commit makes changes to handle tmax timeout error. This means that tmax timeout error occurs, it should be included and recorded in the AdapterError metric as well. Commit updates errorsToMetric() to also consider tmax timeout error. So that tmax timeout error will also be recorded into AdapterError. Link: [1] https://github.com/prebid/prebid-server/blob/2e056bfbc071292361b6c399ed8176ff369babc3/exchange/exchange.go#L675 [2] https://github.com/prebid/prebid-server/blob/2e056bfbc071292361b6c399ed8176ff369babc3/exchange/exchange.go#L719 [3] https://github.com/prebid/prebid-server/blob/2e056bfbc071292361b6c399ed8176ff369babc3/exchange/exchange.go#L687-L689
VeronikaSolovei9
approved these changes
Sep 19, 2023
Sonali-More-Xandr
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a bidderRequest loop, which goes through each bidder request. Inside this loop, PBS sends a request to the bidder server and handles the bidder's response or any errors that may occur.
Within this loop, we gather all errors related to bidders using errorsToMetric() and then record these errors into
AdapterErrorsmetric using RecordAdapterRequest()PR makes changes to handle tmax timeout error. This means that if a tmax timeout error occurs then it should be included and recorded in the
AdapterErrorsmetric as well.