New Adapter: smartx #3109

fkoch-sc · 2023-09-15T08:54:04Z

New adapter for smartx ad server

github-actions · 2023-09-15T08:58:58Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, bc6f73f

smartx

Refer here for heat map coverage report

github.com/prebid/prebid-server/adapters/smartx/smartx.go:20:	Builder			100.0%
github.com/prebid/prebid-server/adapters/smartx/smartx.go:29:	MakeRequests		85.7%
github.com/prebid/prebid-server/adapters/smartx/smartx.go:64:	MakeBids		80.0%
github.com/prebid/prebid-server/adapters/smartx/smartx.go:114:	getMediaTypeForBid	100.0%
total:								(statements)		83.3%

github-actions · 2023-09-19T07:02:32Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 9bc44e2

smartx

Refer here for heat map coverage report

github.com/prebid/prebid-server/adapters/smartx/smartx.go:20:	Builder			100.0%
github.com/prebid/prebid-server/adapters/smartx/smartx.go:29:	MakeRequests		85.7%
github.com/prebid/prebid-server/adapters/smartx/smartx.go:64:	MakeBids		80.0%
github.com/prebid/prebid-server/adapters/smartx/smartx.go:114:	getMediaTypeForBid	100.0%
total:								(statements)		83.3%

gargcreation1992 · 2023-09-20T11:47:13Z

adapters/smartx/smartx.go

+	//println("Builder smartx", config.Endpoint)
+	// initialize the adapter and return it


nitpick - I don't think you need to have this comment here. Please remove them

gargcreation1992 · 2023-09-20T11:47:27Z

adapters/smartx/smartx.go

+	"github.com/prebid/prebid-server/openrtb_ext"
+)
+
+// adapter is a implementation of the adapters.Bidder interface.


nit - please remove this comment.

gargcreation1992 · 2023-09-20T12:13:08Z

adapters/smartx/smartx.go

+// MakeRequests prepares the HTTP requests which should be made to fetch bids.
+func (a *adapter) MakeRequests(openRTBRequest *openrtb2.BidRequest, requestInfo *adapters.ExtraRequestInfo) (requestsToBidder []*adapters.RequestData, errs []error) {
+	// parse the requests answer
+	openRTBRequestJSON, err := json.MarshalIndent(openRTBRequest, "", "   ")


Is there a reason to choose MarshalIndent instead of MarshalJson? I think - adding an indentation would slightly take performance hit. Requesting you to please use MarshalJson if possible.

thank you, debug leftover. adjusted

gargcreation1992 · 2023-09-20T12:13:23Z

adapters/smartx/smartx.go

+
+// MakeRequests prepares the HTTP requests which should be made to fetch bids.
+func (a *adapter) MakeRequests(openRTBRequest *openrtb2.BidRequest, requestInfo *adapters.ExtraRequestInfo) (requestsToBidder []*adapters.RequestData, errs []error) {
+	// parse the requests answer


nit - please remove this comment.

gargcreation1992 · 2023-09-20T12:13:26Z

adapters/smartx/smartx.go

+	}, nil
+}
+
+// MakeRequests prepares the HTTP requests which should be made to fetch bids.


nit - please remove this comment.

gargcreation1992 · 2023-09-20T12:13:30Z

adapters/smartx/smartx.go

+	// parse the requests answer
+	openRTBRequestJSON, err := json.MarshalIndent(openRTBRequest, "", "   ")
+	if err != nil {
+		// can't parse the request, this is an critical error


nit - please remove this comment.

gargcreation1992 · 2023-09-20T12:13:37Z

adapters/smartx/smartx.go

+		return nil, errs
+	}
+
+	// create the HEADER of the request


nit - please remove this comment.

gargcreation1992 · 2023-09-20T12:13:48Z

adapters/smartx/smartx.go

+	}), nil
+}
+
+// MakeBids unpacks the server's response into Bids.


nit - please remove this comment.

gargcreation1992 · 2023-09-20T12:13:52Z

adapters/smartx/smartx.go

+		}
+	}
+
+	// add the new request to the list


nit - please remove this comment.

gargcreation1992 · 2023-09-20T12:14:00Z

adapters/smartx/smartx.go

+	// check HTTP status code 400 - Bad Request
+	// check HTTP status code NOT 200


nit - please remove this comment.

gargcreation1992 · 2023-09-20T12:14:08Z

adapters/smartx/smartx.go

+		return nil, []error{err}
+	}
+
+	// check HTTP status code 204 - No Content


nit - please remove this comment.

gargcreation1992 · 2023-09-20T12:14:16Z

adapters/smartx/smartx.go

+
+	var errs []error
+
+	// loop the SeatBids


nit - please remove this comment.

gargcreation1992 · 2023-09-20T12:14:20Z

adapters/smartx/smartx.go

+
+	// loop the SeatBids
+	for _, seatBid := range response.SeatBid {
+		// loop the Bids


nit - please remove this comment.

gargcreation1992 · 2023-09-20T12:14:23Z

adapters/smartx/smartx.go

+	for _, seatBid := range response.SeatBid {
+		// loop the Bids
+		for i, bid := range seatBid.Bid {
+			// get the MType of the bid


nit - please remove this comment.

gargcreation1992 · 2023-09-20T12:14:27Z

adapters/smartx/smartx.go

+			bidType, err := getMediaTypeForBid(bid)
+
+			if err != nil {
+				// if an error occures add it to the errors list and continue


nit - please remove this comment.

gargcreation1992 · 2023-09-20T12:14:30Z

adapters/smartx/smartx.go

+				continue
+			}
+
+			// add the response to the list


nit - please remove this comment.

gargcreation1992 · 2023-09-20T12:16:12Z

adapters/smartx/smartx.go

+}
+
+func getMediaTypeForBid(bid openrtb2.Bid) (openrtb_ext.BidType, error) {
+	return openrtb_ext.BidTypeVideo, nil


the smartx adapter supports both video and native. This value should be dervied from openrtb2.Bid.MType field.

gargcreation1992 · 2023-09-20T12:17:40Z

static/bidder-info/smartx.yaml

@@ -0,0 +1,14 @@
+endpoint: "https://bid.smartclip.net/bid/1005"
+maintainer:
+  email: "adtech@smartclip.tv"


Sent verification email. Please reply with received.

Mail received, thanks -- but my colleagues pointed out that this mailbox only has left a limited time of life. They are in the process of setting up a new mailbox to be used here as well as with Smartx's Prebid JS. The change with the new mailbox will be committed on Monday.

gargcreation1992

lots of unnecessary comment in code. Please remove it. Also suggested few changes.

- removed comments - removed native as its not used currently

github-actions · 2023-09-21T11:23:32Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, d15a8f6

smartx

Refer here for heat map coverage report

github.com/prebid/prebid-server/adapters/smartx/smartx.go:19:	Builder			100.0%
github.com/prebid/prebid-server/adapters/smartx/smartx.go:25:	MakeRequests		85.7%
github.com/prebid/prebid-server/adapters/smartx/smartx.go:55:	MakeBids		80.0%
github.com/prebid/prebid-server/adapters/smartx/smartx.go:97:	getMediaTypeForBid	100.0%
total:								(statements)		83.3%

Updated email address

onkarvhanumante · 2023-09-28T10:29:43Z

static/bidder-info/smartx.yaml

+endpoint: "https://bid.smartclip.net/bid/1005"
+maintainer:
+  email: "bidding@smartclip.tv"
+gvlVendorID: 115


verified gvl id

~ % curl https://vendor-list.consensu.org/v2/vendor-list.json | jq '.vendors."115"' % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 425k 100 425k 0 0 114k 0 0:00:03 0:00:03 --:--:-- 114k { "id": 115, "name": "smartclip Europe GmbH", "purposes": [ 1, 2, 3, 4, 7, 10 ], "legIntPurposes": [], "flexiblePurposes": [ 2, 7, 10 ], "specialPurposes": [ 1, 2 ], "features": [ 2, 3 ], "specialFeatures": [], "policyUrl": "https://privacy-portal.smartclip.net/en/privacy-policy", "cookieMaxAgeSeconds": 31536000, "usesCookies": true, "cookieRefresh": true, "usesNonCookieAccess": true, "deviceStorageDisclosureUrl": "https://cdn.smartclip.net/iab/deviceStorageDisclosure.json" }

onkarvhanumante · 2023-09-28T10:31:58Z

static/bidder-info/smartx.yaml

@@ -0,0 +1,12 @@
+endpoint: "https://bid.smartclip.net/bid/1005"


endpoint is reachable

~ % curl -i https://bid.smartclip.net/bid/1005 HTTP/2 405 server: nginx/1.17.6 date: Thu, 28 Sep 2023 10:30:07 GMT content-length: 0 via: 1.1 google alt-svc: h3=":443"; ma=2592000,h3-29=":443"; ma=2592000

@fkoch-sc, can you provide details on endpoint specifically what does 1005 corresponds to?

1005 is the dedicated endpoint for prebid server in our system. prebid js uses 1000 instead. Helps to keep services separate and tidy.

static/bidder-info/smartx.yaml

openrtb_ext/bidders.go

adapters/smartx/smartx.go

onkarvhanumante · 2023-09-28T10:44:58Z

adapters/smartx/smartx.go

+func getMediaTypeForBid(bid openrtb2.Bid) (openrtb_ext.BidType, error) {
+	return openrtb_ext.BidTypeVideo, nil


As of now, getMediaTypeForBid() only returns openrtb_ext.BidTypeVideo. Instead skimpily assign openrtb_ext.BidTypeVideo as BidType

bidResponse.Bids = append(bidResponse.Bids, &adapters.TypedBid{ Bid: &seatBid.Bid[i], BidType: openrtb_ext.BidTypeVideo, })

onkarvhanumante · 2023-09-28T10:48:53Z

@fkoch-sc should create docs PR in https://github.com/prebid/prebid.github.io repo. Note that this docs will be used as guideline for publisher to work with smartx adapter.

github-actions · 2023-09-29T10:54:57Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 0616f85

smartx

Refer here for heat map coverage report

github.com/prebid/prebid-server/adapters/smartx/smartx.go:19:	Builder			100.0%
github.com/prebid/prebid-server/adapters/smartx/smartx.go:25:	MakeRequests		85.7%
github.com/prebid/prebid-server/adapters/smartx/smartx.go:55:	MakeBids		80.0%
github.com/prebid/prebid-server/adapters/smartx/smartx.go:97:	getMediaTypeForBid	100.0%
total:								(statements)		83.3%

- safeguard currency - removed mediaType function as we only support video for now

github-actions · 2023-09-29T11:00:00Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 7cd6376

smartx

Refer here for heat map coverage report

github.com/prebid/prebid-server/adapters/smartx/smartx.go:19:	Builder		100.0%
github.com/prebid/prebid-server/adapters/smartx/smartx.go:25:	MakeRequests	85.7%
github.com/prebid/prebid-server/adapters/smartx/smartx.go:55:	MakeBids	88.2%
total:								(statements)	87.5%

adapters/smartx/smartx_test.go

onkarvhanumante · 2023-09-29T20:32:43Z

@fkoch-sc

Tests are failing with following error

Run ./validate.sh --nofmt --cov --race 10
gofmt needs to be run, 1 files have issues.  Below is a list of files to review:
adapters/smartx/smartx.go
Error: Process completed with exit code 1.

github-actions · 2023-09-29T20:41:28Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 1a66d09

smartx

Refer here for heat map coverage report

github.com/prebid/prebid-server/adapters/smartx/smartx.go:19:	Builder		100.0%
github.com/prebid/prebid-server/adapters/smartx/smartx.go:25:	MakeRequests	85.7%
github.com/prebid/prebid-server/adapters/smartx/smartx.go:55:	MakeBids	88.2%
total:								(statements)	87.5%

- sorted smartx alpabetically into bidders - ran gofmt on the smartx adapter - adjusted test url

github-actions · 2023-09-29T20:53:17Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 5763e95

smartx

Refer here for heat map coverage report

github.com/prebid/prebid-server/adapters/smartx/smartx.go:19:	Builder		100.0%
github.com/prebid/prebid-server/adapters/smartx/smartx.go:25:	MakeRequests	85.7%
github.com/prebid/prebid-server/adapters/smartx/smartx.go:55:	MakeBids	88.2%
total:								(statements)	87.5%

fkoch-sc · 2023-10-05T06:53:32Z

@fkoch-sc should create docs PR in https://github.com/prebid/prebid.github.io repo. Note that this docs will be used as guideline for publisher to work with smartx adapter.

PR created: prebid/prebid.github.io#4912

gargcreation1992 · 2023-10-06T09:06:14Z

adapters/smartx/smartx.go

+	if err := adapters.CheckResponseStatusCodeForErrors(responseData); err != nil {
+		return nil, []error{err}
+	}
+
+	if adapters.IsResponseStatusCodeNoContent(responseData) {
+		return nil, nil
+	}


you might wanna reverse this. You should check for no content first before you check CheckResponseStatusCodeForErrors because CheckResponseStatusCodeForErrors function will return an error even if response from bidder is 204 which is StatusNoContent. So -

if adapters.IsResponseStatusCodeNoContent(responseData) { return nil, nil } if err := adapters.CheckResponseStatusCodeForErrors(responseData); err != nil { return nil, []error{err} }

github-actions · 2023-10-06T18:21:26Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 4fb973a

smartx

Refer here for heat map coverage report

github.com/prebid/prebid-server/adapters/smartx/smartx.go:19:	Builder		100.0%
github.com/prebid/prebid-server/adapters/smartx/smartx.go:25:	MakeRequests	85.7%
github.com/prebid/prebid-server/adapters/smartx/smartx.go:55:	MakeBids	88.2%
total:								(statements)	87.5%

onkarvhanumante · 2023-10-09T06:30:27Z

@fkoch-sc, docs PR is failing please take a look - prebid/prebid.github.io#4912 (comment)

Co-authored-by: Andreas Schubert <as@burgeins.de> Co-authored-by: schubert-sc <144821265+schubert-sc@users.noreply.github.com>

Andreas Schubert added 2 commits September 15, 2023 10:32

new adapter smartx

8a87fea

fix parameter tests

bc6f73f

gargcreation1992 assigned gargcreation1992 and onkarvhanumante Sep 15, 2023

fix typo in Builder

9bc44e2

gargcreation1992 reviewed Sep 20, 2023

View reviewed changes

adapters/smartx/smartx.go Outdated

}

}

// add the new request to the list

Copy link

Contributor

gargcreation1992 Sep 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit - please remove this comment.

gargcreation1992 reviewed Sep 20, 2023

View reviewed changes

adapters/smartx/smartx.go Outdated

var errs []error

// loop the SeatBids

Copy link

Contributor

gargcreation1992 Sep 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit - please remove this comment.

gargcreation1992 reviewed Sep 20, 2023

View reviewed changes

adapters/smartx/smartx.go Outdated

continue

}

// add the response to the list

Copy link

Contributor

gargcreation1992 Sep 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit - please remove this comment.

gargcreation1992 reviewed Sep 20, 2023

View reviewed changes

bsardo changed the title ~~new adapter smartx~~ New Adapter: smartx Sep 20, 2023

review adjustments

d15a8f6

- removed comments - removed native as its not used currently

Update smartx.yaml

50d74b9

Updated email address

onkarvhanumante reviewed Sep 28, 2023

View reviewed changes

static/bidder-info/smartx.yaml Show resolved Hide resolved

onkarvhanumante reviewed Sep 28, 2023

View reviewed changes

openrtb_ext/bidders.go Outdated Show resolved Hide resolved

onkarvhanumante reviewed Sep 28, 2023

View reviewed changes

adapters/smartx/smartx.go Outdated Show resolved Hide resolved

onkarvhanumante reviewed Sep 28, 2023

View reviewed changes

Merge branch 'prebid:master' into master

0616f85

adjusted based on feedback

7cd6376

- safeguard currency - removed mediaType function as we only support video for now

onkarvhanumante reviewed Sep 29, 2023

View reviewed changes

adapters/smartx/smartx_test.go Outdated Show resolved Hide resolved

Merge branch 'prebid:master' into master

1a66d09

feedback adjustments

5763e95

- sorted smartx alpabetically into bidders - ran gofmt on the smartx adapter - adjusted test url

onkarvhanumante previously approved these changes Oct 3, 2023

View reviewed changes

schubert-sc mentioned this pull request Oct 4, 2023

update smartx documentation for support pbs prebid/prebid.github.io#4912

Merged

2 tasks

gargcreation1992 reviewed Oct 6, 2023

View reviewed changes

check no content before error

4fb973a

schubert-sc dismissed onkarvhanumante’s stale review via 4fb973a October 6, 2023 18:20

onkarvhanumante approved these changes Oct 9, 2023

View reviewed changes

gargcreation1992 approved these changes Oct 9, 2023

View reviewed changes

gargcreation1992 merged commit 23bc394 into prebid:master Oct 9, 2023
5 checks passed

cross-repo-issue-creation bot mentioned this pull request Oct 9, 2023

Port PR from PBS-Go: New Adapter: smartx prebid/prebid-server-java#2683

Closed

svamiftah pushed a commit to sovrn/prebid-server that referenced this pull request Nov 21, 2023

New Adapter: smartx (prebid#3109)

976375d

Co-authored-by: Andreas Schubert <as@burgeins.de> Co-authored-by: schubert-sc <144821265+schubert-sc@users.noreply.github.com>

		//println("Builder smartx", config.Endpoint)
		// initialize the adapter and return it

		// check HTTP status code 400 - Bad Request
		// check HTTP status code NOT 200

		@@ -0,0 +1,12 @@
		endpoint: "https://bid.smartclip.net/bid/1005"

		func getMediaTypeForBid(bid openrtb2.Bid) (openrtb_ext.BidType, error) {
		return openrtb_ext.BidTypeVideo, nil

New Adapter: smartx #3109

New Adapter: smartx #3109

Conversation

fkoch-sc commented Sep 15, 2023

github-actions bot commented Sep 15, 2023

Code coverage summary

smartx

github-actions bot commented Sep 19, 2023

Code coverage summary

smartx

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gargcreation1992 left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 21, 2023

Code coverage summary

smartx

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

onkarvhanumante commented Sep 28, 2023

github-actions bot commented Sep 29, 2023

Code coverage summary

smartx

github-actions bot commented Sep 29, 2023

Code coverage summary

smartx

onkarvhanumante commented Sep 29, 2023

github-actions bot commented Sep 29, 2023

Code coverage summary

smartx

github-actions bot commented Sep 29, 2023

Code coverage summary

smartx

fkoch-sc commented Oct 5, 2023

Choose a reason for hiding this comment

github-actions bot commented Oct 6, 2023

Code coverage summary

smartx

onkarvhanumante commented Oct 9, 2023