make case insensitive comparison in auction request #3113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endpoints/openrtb2/sample-requests/valid-whole/exemplary/simple.json
Outdated
Show resolved
Hide resolved
endpoints/openrtb2/sample-requests/valid-whole/exemplary/all-ext.json
Outdated
Show resolved
Hide resolved
hhhjort
reviewed
Sep 20, 2023
hhhjort
reviewed
Sep 20, 2023
onkarvhanumante
approved these changes
Sep 25, 2023
AvinashKapre
pushed a commit
to PubMatic-OpenWrap/prebid-server
that referenced
this pull request
Oct 26, 2023
pm-nilesh-chate
pushed a commit
to PubMatic-OpenWrap/prebid-server
that referenced
this pull request
Oct 27, 2023
Co-authored-by: Ashish Garg <gargcreation1992@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to make case insensitive comparison in the request while in the response we should return the same bidder name(with whatever case) from the request.
By doing case insensitive comparison in the request, we are not making any changes in our current auction flow. Our current auction flow will work the same way as it is today.
partially resolves - #2400