Make user.ext.prebid.buyeruids bidder name case insensitive #3123
Conversation
gargcreation1992
dismissed
onkarvhanumante’s stale review
The base branch was changed.
| @@ -0,0 +1,77 @@ | |||
| { | |||
There was a problem hiding this comment.
Could you also add a test using a bidder name where it's original formatting isn't already lowercase (i.e. yahooAds)
There was a problem hiding this comment.
Added in 8b7a55b
| normalisedBidderName, _ := openrtb_ext.NormalizeBidderName(bidderName) | ||
| coreBidderName := normalisedBidderName.String() | ||
| if _, isCoreBidderDisabled := deps.disabledBidders[coreBidderName]; isCoreBidderDisabled { | ||
| return fmt.Errorf("request.ext.prebid.aliases.%s refers to disabled bidder: %s", alias, bidderName) |
There was a problem hiding this comment.
Why was this changed? I think validateAliases were changed in - https://github.com/prebid/prebid-server/pull/3123/files#diff-23485c351c14cdca5e337d1c05105bd3a9b7308b017589654f0854ff4f9a7ff1 PR.
There was a problem hiding this comment.
this happened because base PR PBS-1254-1 which added changes for validateAliases was merged and deleted. Due to which commits from PBS-1254-1 got added in PBS-1257
|
Closing this PR since it has some commits from PBS-1254-1. Created a new PR with commits related to PBS-1257 only. |
We need to handle case insensitivity for user.ext.prebid.buyeruids biddernames. This PR updates the biddername look up to use the normalized names for buyeruids.BIDDER.
partially resolves #2400