Pass "req.ext.prebid.targeting.includebrandcategory" To Bidders #3817
Conversation
| @@ -105,8 +105,7 @@ | |||
| ] | |||
| }, | |||
| "includewinners": true, | |||
| "includebidderkeys": true, | |||
| "mediatypepricegranularity": {} | |||
There was a problem hiding this comment.
Changed mediatypepricegranularity and publisher to be omitted when empty. Not sure why this wasn't done initially. I doubt it was intentional.
|
Hi @SyntaxNode, we recently released PBS 3.0, more specifically v3.1.0, which updates Prebid Server package import references throughout the project from As a result, please merge with master (no rebase) and then ensure all Prebid Server package import references in the files you’ve changed are |
exchange/utils_test.go
Outdated
| @@ -3676,6 +3728,7 @@ func TestBuildExtData(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| // fails | |||
|
endpoints/openrtb2/auction.go
Outdated
| if err := validatePriceGranularity(t.MediaTypePriceGranularity.Video); err != nil { | ||
| } | ||
|
|
||
| if mediaPriceGranularity := t.MediaTypePriceGranularity; mediaPriceGranularity != nil { |
There was a problem hiding this comment.
Why are you making a copy of t.MediaTypePriceGranularity? It doesn't seem to be to protect the original from accidental modification.
There was a problem hiding this comment.
This PR changes the MediaTypePriceGranularity field on the ExtRequestTargeting struct from a value to a pointer to match the rest of the targeting object. It looks like MediaTypePriceGranularity was intended to be a pointer since it has the omitemty directive which I noticed during this change wasn't working.
Therefore, this is not a copy. I'm assigning t.MediaTypePriceGranularity to a local variable to simplify the references from t.MediaTypePriceGranularity to directly mediaPriceGranularity .
There was a problem hiding this comment.
Changed for clarity. If this syntax isn't clear, likely not a great idea.
|
I just have that one little nitpick, otherwise it looks good. |
Addresses #3305 for PBS-Go.