Adkernel: rxnetwork alias #3956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
SyntaxNode
reviewed
Oct 21, 2024
static/bidder-info/rxnetwork.yaml
Outdated
| @@ -0,0 +1,2 @@ | |||
| aliasOf: adkernel | |||
| gvlVendorID: 14 | |||
There was a problem hiding this comment.
Checking to ensure the use of adkernel's TCF vendor code is appropriate within the context of the RxNetwork alias.
There was a problem hiding this comment.
@SyntaxNode I've intentionally specified Adkernel's gvlid to claim GDPR support. I saw a similar approach in other aliased adaptors.
There was a problem hiding this comment.
There's no need to specify it here. It will be automatically picked up with the alias.
There was a problem hiding this comment.
@SyntaxNode ok, updated
SyntaxNode
approved these changes
Nov 5, 2024
bsardo
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added alias for partner network to resolve an issue with multiple connected networks via same adkernel bidder.