New Adapter: Mediasquare #3994
Open
New Adapter: Mediasquare #3994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…' into mediasquare_adapter
Code coverage summaryNote:
mediasquareRefer here for heat map coverage report |
Code coverage summaryNote:
mediasquareRefer here for heat map coverage report |
mediasquare-alexandre
changed the title
static/bidder-info/mediasquare.yaml
Outdated
| @@ -0,0 +1,12 @@ | |||
| endpoint: "http://pbs-front.mediasquare.fr/msq_prebid" | |||
There was a problem hiding this comment.
503 response, please fix
|
@mediasquare-alexandre Hi, I’m wondering why these tests were written in this way. In most adapters, we approach it by having a TestJsonSamples class, where we write JSON files to check our scenarios, like simple-banner.json, bad_media_type, etc. Additionally, we add a params_test class to verify validParams and invalidParams. |
Code coverage summaryNote:
mediasquareRefer here for heat map coverage report |
Hi Guys, honestly when I started doing my tests I remembered my PR 2 years ago here where most of my reviewers asked me to increase the code-coverage as much as possible. #2215 |
Code coverage summaryNote:
mediasquareRefer here for heat map coverage report |
Code coverage summaryNote:
mediasquareRefer here for heat map coverage report |
Code coverage summaryNote:
mediasquareRefer here for heat map coverage report |
|
Hi Guys, @przemkaczmarek @bsardo |
| } | ||
|
|
||
| msqParams := initMsqParams(request) | ||
| msqParams.Test = (request.Test == int8(1)) |
There was a problem hiding this comment.
I haven't seen this behavior before. Is this added because the msqParams.Test field is required by the MediaSquare backend to recognize the request as a test?
There was a problem hiding this comment.
Yes, it is.
|
@mediasquare-alexandre It's great that you decided to add the adapterstest.RunJSONBidderTest methods. |
Comment on lines
+21
to
+26
| // MakeRequests : case request is empty. | ||
| resp, errs := bidder.MakeRequests(nil, nil) | ||
| expectingErrors := []error{errorWritter("<MakeRequests> request", nil, true)} | ||
| assert.Equal(t, []*adapters.RequestData(nil), resp, "resp, was supposed to be empty result.") | ||
| assert.Equal(t, expectingErrors, errs, "errs, was supposed to be :", expectingErrors) | ||
|
|
There was a problem hiding this comment.
This should be tested in JSON files.
There was a problem hiding this comment.
I initially would have if it was possible,
// MakeRequests : case request is empty.
resp, errs := bidder.MakeRequests(nil, nil)
Here is a screen-shot of the following test :
Cordially
There was a problem hiding this comment.
I have had, let this test be :
Tell me if you want me to take it back, it will reduce the coverage by 2% or so... But it is not critical.
|
@mediasquare-alexandre This still doesn't meet our standards, e.g., there's no params_test.go file where you would test validParams and invalidParams (for your required owner and code). |
Code coverage summaryNote:
mediasquareRefer here for heat map coverage report |
|
@przemkaczmarek I tried to use your naming for tests-files, but I'm not sure the names I put on are ok... The documentation only show that files have to be formated as json in supplemental & examplary, so it doesn't help me neither on this subject. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces the Mediasquare bidder adapter for Prebid Server. It supports the following mediatypes:
Endpoint: "https://pbs-front.mediasquare.fr/msq_prebid"
Endpoint Compression: gzip
GVL Vendor ID: 791
Test Status
Unit tests: All tests passed.
Maintainer Contact
emails:
About us
https://www.mediasquare.fr/