New Adapter: Kueez

[saar120]

No description provided.

[github-actions]

Code coverage summary

Note:

• Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
• Coverage summary encompasses all commits leading up to the latest one, bf7ab42

kueezrtb

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/kueezrtb/kueezrtb.go:23:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/kueezrtb/kueezrtb.go:30:	MakeRequests		77.8%
github.com/prebid/prebid-server/v3/adapters/kueezrtb/kueezrtb.go:68:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/kueezrtb/kueezrtb.go:80:	MakeBids		89.5%
github.com/prebid/prebid-server/v3/adapters/kueezrtb/kueezrtb.go:123:	extractCid		71.4%
total:									(statements)		84.0%

[przemkaczmarek]

endpoint doesnt work

[saar120]

@przemkaczmarek
You need to add the cId to the request

prebid-server/adapters/kueezrtb/kueezrtb.go

Lines 54 to 62 in bf7ab42

	requestData := &adapters.RequestData{
	Method: "POST",
	Uri: fmt.Sprintf("%s%s", a.endpoint, url.QueryEscape(cId)),
	Body: requestJSON,
	Headers: headers,
	ImpIDs: []string{imp.ID},
	}
	requests = append(requests, requestData)

[saar120]

@przemkaczmarek
Can we approve please?

[przemkaczmarek]

endpoint works

[przemkaczmarek]

it works

[przemkaczmarek]

what happend if You add:
var invalidParams = []string{
{},
{"cId": 123},
{"cId": true},
{"cId": null},
{"cId": ""},
{"cId": " "},
{"cId": "cid_with_invalid_chars!@#"},
{"cId": "valid_cid", "extra_field": "unexpected"},
{"cId": "a_very_long_connection_id_exceeding_the_maximum_allowed_length_..."},
[],
["cId"],
"string_value",
42,
true,
{"cId": "valid_cid",
{"cId":},
{"cid": "valid_cid"},
}
please add more invalidParams

[saar120]

Added more..

[github-actions]

Code coverage summary

Note:

• Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
• Coverage summary encompasses all commits leading up to the latest one, b76086d

kueezrtb

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/kueezrtb/kueezrtb.go:23:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/kueezrtb/kueezrtb.go:30:	MakeRequests		77.8%
github.com/prebid/prebid-server/v3/adapters/kueezrtb/kueezrtb.go:68:	MakeBids		89.5%
github.com/prebid/prebid-server/v3/adapters/kueezrtb/kueezrtb.go:111:	extractCid		71.4%
github.com/prebid/prebid-server/v3/adapters/kueezrtb/kueezrtb.go:124:	getMediaTypeForBid	100.0%
total:									(statements)		84.0%

[bsardo]

Hi @saar120, we noticed that your adapter is basically the same as the Vidazoo adapter. We would like to point out that aliasing an adapter may be an option for you and is preferable if you and another bidder share the same server. You can read more about aliasing here: aliasing an adapter.

Please let us know your thoughts on whether this is a possibility for you.

[saar120]

Hey @bsardo
We are providing the adapter and the server as a white label solution.
KueezRtb and Vidazoo are different entities and should not share the same adapter.
For now this solution does not fit our needs.

[assa-kariv]

@przemkaczmarek are we waiting for an additional approval? we would really appreciate if it could be included in the following release

[przemkaczmarek]

@assa-kariv In our policy, we require two approvals.

[assa-kariv]

@przemkaczmarek yeah I am aware of that thanks for tagging another approver

[saar120]

@bsardo
Can you please help with a review?