Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blue: Add placementId bidder param #4051

Merged
merged 7 commits into from
Dec 10, 2024
50 changes: 50 additions & 0 deletions adapters/blue/params_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
package blue

import (
"encoding/json"
"testing"

"github.com/prebid/prebid-server/v3/openrtb_ext"
)

// This file actually intends to test static/bidder-params/blue.json TODO: MUST BE CREATED
samuelfabel marked this conversation as resolved.
Show resolved Hide resolved
func TestValidParams(t *testing.T) {
validator, err := openrtb_ext.NewBidderParamsValidator("../../static/bidder-params")
if err != nil {
t.Fatalf("Failed to fetch the json-schemas. %v", err)
}

for _, validParam := range validParams {
if err := validator.Validate(openrtb_ext.BidderBlue, json.RawMessage(validParam)); err != nil {
t.Errorf("Schema rejected blue params: %s", validParam)
}
}
}

func TestInvalidParams(t *testing.T) {
validator, err := openrtb_ext.NewBidderParamsValidator("../../static/bidder-params")
if err != nil {
t.Fatalf("Failed to fetch the json-schemas. %v", err)
}

for _, invalidParam := range invalidParams {
if err := validator.Validate(openrtb_ext.BidderBlue, json.RawMessage(invalidParam)); err == nil {
t.Errorf("Schema allowed unexpected params: %s", invalidParam)
}
}
}

var validParams = []string{
`{"publisherId":"1234"}`,
`{"publisherId":"1234", "placementId":"12345"}`,
samuelfabel marked this conversation as resolved.
Show resolved Hide resolved
}

var invalidParams = []string{
``,
`null`,
`true`,
`5`,
`4.2`,
`[]`,
`{}`,
samuelfabel marked this conversation as resolved.
Show resolved Hide resolved
}
6 changes: 5 additions & 1 deletion static/bidder-params/blue.json
samuelfabel marked this conversation as resolved.
Show resolved Hide resolved
samuelfabel marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@
"description": "A schema which validates params accepted by the Blue adapter",
"type": "object",
"properties": {
"placementId": {
"type": "string",
"description": "Placement ID provided by Blue"
},
"publisherId": {
"type": "string",
"description": "The publisher’s ID provided by Blue"
Expand All @@ -12,4 +16,4 @@
"required": [
"publisherId"
]
}
}
Loading