Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Adapter: Bidtheatre #4069

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

andreasgreen
Copy link

var bidExt openrtb_ext.ExtBid
err := jsonutil.Unmarshal(bid.Ext, &bidExt)
if err == nil && bidExt.Prebid != nil {
return openrtb_ext.ParseBidType(string(bidExt.Prebid.Type))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider this as a suggestion. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, recommends implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.

Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 3eee6c5

bidtheatre

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/bidtheatre/bidtheatre.go:21:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/bidtheatre/bidtheatre.go:29:	MakeRequests		80.0%
github.com/prebid/prebid-server/v3/adapters/bidtheatre/bidtheatre.go:46:	getMediaTypeForBid	83.3%
github.com/prebid/prebid-server/v3/adapters/bidtheatre/bidtheatre.go:60:	MakeBids		69.6%
github.com/prebid/prebid-server/v3/adapters/bidtheatre/bidtheatre.go:105:	resolveMacros		80.0%
total:										(statements)		75.6%

- EEA
maintainer:
email: operations@bidtheatre.com
gvlVendorID: 30
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  "id": 30,
  "name": "BidTheatre AB",
  "purposes": [1, 3, 4, 7],
  "legIntPurposes": [2],
  "flexiblePurposes": [2, 7],
  "specialPurposes": [1, 2, 3],
  "features": [2],
  "specialFeatures": [],
  "cookieMaxAgeSeconds": 7776000,
  "usesCookies": true,
  "cookieRefresh": true,
  "urls": [
    {
      "langId": "en",
      "privacy": "https://www.bidtheatre.com/privacy-policy",
      "legIntClaim": "https://cdn.bidtheatre.com/LIA_ferq.pdf"
    }
  ],
  "usesNonCookieAccess": false,
  "dataRetention": {
    "purposes": {
      "2": 7,
      "3": 60,
      "4": 0,
      "7": 180
    },
    "specialPurposes": {
      "1": 30,
      "2": 7,
      "3": 180
    }
  },
  "dataDeclaration": [1, 2, 3, 4, 5, 6, 8, 10, 11],
  "deviceStorageDisclosureUrl": "https://privacy.bidtheatre.com/deviceStorage.json"
},```
confirmed

@@ -0,0 +1,20 @@
endpoint: "https://prebidjs-bids.bidtheatre.net/prebidjsbid"
Copy link
Collaborator

@przemkaczmarek przemkaczmarek Nov 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works
image

- video
userSync:
redirect:
url: https://match.adsby.bidtheatre.com/usersync?gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&cb={{.RedirectURL}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for redirect we should get 302 not 200
Uploading image.png…

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @przemkaczmarek ,

We require redirect domains to be explicitly whitelisted to perform the redirect, so in this case no redirect is actually made. This means we will need to whitelist each onboarded publisher's prebid-server domain.

See correct 302 redirect for this whitelisted domain as an example:

https://match.adsby.bidtheatre.com/usersync?gdpr=0&gdpr_consent=&cb=https%3A%2F%2Fid5-sync.com%3Fuid%3D%7Buid%7D

Comment on lines +10 to +11
"minLength": 36,
"maxLength": 36
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed 36 was used as the request number. Could you explain the reasoning? Just want to ensure I fully understand

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will require publishers to be approved before we will bid on their inventory via Prebid. Upon approval the publisher will be assigned an UUID , this UUID is a string and always 36 characters long and at this time the only required bid param.

@przemkaczmarek przemkaczmarek self-assigned this Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants