Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Adapter: AdUp Tech #4076

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

danygielow
Copy link

@danygielow danygielow commented Nov 26, 2024

Hello,

We as AdUp Technology want to add our own Prebid Server Adapter.
We already have a PrebidJS Adapter.

Docs: prebid/prebid.github.io#5728

}

func getBidType(markupType openrtb2.MarkupType) (openrtb_ext.BidType, error) {
switch markupType {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeBanner. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.

}

func getBidType(markupType openrtb2.MarkupType) (openrtb_ext.BidType, error) {
switch markupType {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeNative. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.

Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 74112fe

aduptech

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/aduptech/aduptech.go:23:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/aduptech/aduptech.go:32:	MakeRequests	53.8%
github.com/prebid/prebid-server/v3/adapters/aduptech/aduptech.go:63:	convertCurrency	0.0%
github.com/prebid/prebid-server/v3/adapters/aduptech/aduptech.go:90:	MakeBids	63.6%
github.com/prebid/prebid-server/v3/adapters/aduptech/aduptech.go:136:	getBidType	75.0%
total:									(statements)	49.1%

@danygielow danygielow force-pushed the feat/add-aduptech-adapter branch from 74112fe to 8e94b4b Compare November 27, 2024 06:32
}

func getBidType(markupType openrtb2.MarkupType) (openrtb_ext.BidType, error) {
switch markupType {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeBanner. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.

}

func getBidType(markupType openrtb2.MarkupType) (openrtb_ext.BidType, error) {
switch markupType {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider this as a suggestion. The current implementation follows an anti-pattern, assumes that if there is a multi-format request, the media type defaults to openrtb_ext.BidTypeNative. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, we strongly recommend implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.

Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 8e94b4b

aduptech

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/aduptech/aduptech.go:23:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/aduptech/aduptech.go:32:	MakeRequests	84.6%
github.com/prebid/prebid-server/v3/adapters/aduptech/aduptech.go:63:	convertCurrency	75.0%
github.com/prebid/prebid-server/v3/adapters/aduptech/aduptech.go:90:	MakeBids	63.6%
github.com/prebid/prebid-server/v3/adapters/aduptech/aduptech.go:136:	getBidType	75.0%
total:									(statements)	73.6%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant