Admatic: Add headers #4083
Open
Admatic: Add headers #4083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code coverage summaryNote:
admaticRefer here for heat map coverage report |
Code coverage summaryNote:
admaticRefer here for heat map coverage report |
bsardo
reviewed
Dec 12, 2024
Comment on lines
+38
to
+53
| headers := http.Header{} | ||
| headers.Add("Content-Type", "application/json;charset=utf-8") | ||
| headers.Add("Accept", "application/json") | ||
| if request.Device != nil { | ||
| if len(request.Device.UA) > 0 { | ||
| headers.Add("User-Agent", request.Device.UA) | ||
| } | ||
|
|
||
| if len(request.Device.IPv6) > 0 { | ||
| headers.Add("X-Forwarded-For", request.Device.IPv6) | ||
| } | ||
|
|
||
| if len(request.Device.IP) > 0 { | ||
| headers.Add("X-Forwarded-For", request.Device.IP) | ||
| } | ||
| } |
There was a problem hiding this comment.
Please add JSON test coverage for this logic by adding and/or updating 2 JSON tests, one where device is nil and one where device is not nil with ua, ip and ipv6 set. You can verify the headers are set correctly by including the following in your JSON test:
"httpCalls": [
{
"expectedRequest": {
"headers": {
"Content-Type": [
"application/json;charset=utf-8"
],
"Accept": [
"application/json"
],
etc...
``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.