MetaX: Add BidVideo for video ads #4095
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kehan Pan <kehan.pan@metaxsoft.com>
Code coverage summaryNote:
metaxRefer here for heat map coverage report |
bsardo
reviewed
Dec 12, 2024
Comment on lines
+183
to
+188
| if len(bid.Cat) > 0 { | ||
| bidVideo.PrimaryCategory = bid.Cat[0] | ||
| } | ||
| if bid.Dur > 0 { | ||
| bidVideo.Duration = int(bid.Dur) | ||
| } |
There was a problem hiding this comment.
Can you please update one of your exemplary JSON tests so that the bid response contains a cat and dur? While the unit tests are nice they aren't required while coverage through JSON tests are.
There was a problem hiding this comment.
updated one JSON test
adapters/metax/metax_test.go
Outdated
Comment on lines
179
to
181
| bidVideo := getBidVideo(test.bid) | ||
| assert.Equal(t, test.bidvideo.PrimaryCategory, bidVideo.PrimaryCategory) | ||
| assert.Equal(t, test.bidvideo.Duration, bidVideo.Duration) |
There was a problem hiding this comment.
Please wrap this in a t.Run( call. You can find examples in the code base.
Signed-off-by: Kehan Pan <kehan.pan@metaxsoft.com>
Code coverage summaryNote:
metaxRefer here for heat map coverage report |
bsardo
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add duration and category data to TypedBid