New Adapter: Pixfuture #4105
Open
New Adapter: Pixfuture #4105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| // Builder builds a new instance of the Pixfuture adapter. | ||
| func Builder(bidderName openrtb_ext.BidderName, config config.Adapter, server config.Server) (adapters.Bidder, error) { | ||
| bidder := &PixfutureAdapter{ |
There was a problem hiding this comment.
You can call this simply "adapter", the PixfutureAdapter identification is already supplied by the package name. As you have it, referencing your adapter from outside the package would be PixfutureAdapter.PixfutureAdapter which looks a little redundant. See example below:
package foo
type adapter struct {
endpoint string
}
func Builder(bidderName openrtb_ext.BidderName, config config.Adapter, server config.Server) (adapters.Bidder, error) {
return &adapter{endpoint: "https://www.foo.com"}, nil
}
| var bidExt openrtb_ext.ExtBid | ||
| err := jsonutil.Unmarshal(bid.Ext, &bidExt) | ||
| if err == nil && bidExt.Prebid != nil { | ||
| return openrtb_ext.ParseBidType(string(bidExt.Prebid.Type)) |
There was a problem hiding this comment.
Consider this as a suggestion. Prebid server expects the media type to be explicitly set in the adapter response. Therefore, recommends implementing a pattern where the adapter server sets the MType field in the response to accurately determine the media type for the impression.
Code coverage summaryNote:
pixfutureRefer here for heat map coverage report |
bsardo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We have developed a new Prebid Server adapter and are proposing its addition to the master branch for review.
Changes
Implemented a new Prebid Server adapter.
Added unit tests to ensure functionality.
Updated documentation with usage instructions and parameters.
Reason for Change
This new adapter will allow for more robust and flexible bidding options, enhancing our server-side header bidding capabilities.
Testing
Passed all unit tests.
Successfully integrated with our test environment and confirmed expected behavior.
No breaking changes detected in existing functionality.
Request
Please review the code changes and provide feedback. Once approved, we will merge this adapter into the master branch.