Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial RhythmOne Prebid Server Adapter #704
Initial RhythmOne Prebid Server Adapter #704
Changes from 3 commits
fbe205b
e79e61b
c8c33d5
e13ed9a
deb60d2
1eadb45
35beb9e
f9d02e0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This field is unused... it can be deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Name() and SkipNoCookies() are legacy things... you don't need them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can delete this block. The
adapters.EnforceBidderInfo()
call inadapter_map
makes sure your Imps have valid formats, according to yourstatic/bidder-info/rhythmone.yaml
definitions.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here. This is guaranteed by the
EnforceBidderInfo()
stuff.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This
if imp.Banner != nil && imp.Video != nil {
block is a no-op, and can be deleted.If both are non-nil, the
if imp.Banner != nil {
block will already have set this to BidTypeBanner.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function is unused, and can be deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
client
is unused... please remove it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since
req.Imp
is a slice, and a slice is essentially a pointer to an existing array structure,requestImpCopy := req.Imp
will end up referencing the same underlying array asreq.Imp
So it is not a true copy.You only seem to use
reqestImpCopy
forimp := requestImpCopy[i]
, which will makeimp
a copy shallow of the originalimp
. So there does not seem to be a reason to definereqestImpCopy
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two blocks can go away... audio/native aren't possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This
if
clause can go away too. At least one of Banner or Video are guaranteed to be non-nil by theEnforceBidderInfo()
thing.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This constraint should go in your
static/bidder-params/rhythmone.json
schema as aminlength
: https://json-schema.org/understanding-json-schema/reference/string.html#lengthThen you can remove this logic here. If the params don't validate against that schema, your adapter won't be called.