Brightroll auction type explicitly default to first price auction #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smithaammassamveettil
force-pushed
the
master
branch
from
897c8d5
to
245a8fb
Compare
dbemiller
approved these changes
Nov 12, 2018
|
@dbemiller , Thanks for reviewing and approving. Can you please merge the changes to master as well? |
|
Takes 2 approvals to merge. It will make it in eventually |
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 1, 2020
…ebid#746) * Brightroll auction type explicitly default to first price auction * fixed merge issue * removed unnessary code
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 2, 2020
…ebid#746) * Brightroll auction type explicitly default to first price auction * fixed merge issue * removed unnessary code
katsuo5
pushed a commit
to flux-dev-team/prebid-server-1
that referenced
this pull request
Dec 4, 2020
…ebid#746) * Brightroll auction type explicitly default to first price auction * fixed merge issue * removed unnessary code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Explicity setting the auction type to 1 for first price auction in Brightroll adaptor