-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue862 - implemented multi media bids #993
Commits on Jul 1, 2019
-
jim committed
Jul 1, 2019 Configuration menu - View commit details
-
Copy full SHA for e9fa33d - Browse repository at this point
Copy the full SHA e9fa33dView commit details
Commits on Jul 9, 2019
-
Merge remote-tracking branch 'origin/master' into issue862
jim committedJul 9, 2019 Configuration menu - View commit details
-
Copy full SHA for 58e10da - Browse repository at this point
Copy the full SHA 58e10daView commit details -
Improved handling of imps that are looking for both banner and video.…
… This requires using aliases. Updated the documentation and similar to descrbe that.
jim committedJul 9, 2019 Configuration menu - View commit details
-
Copy full SHA for 9975473 - Browse repository at this point
Copy the full SHA 9975473View commit details
Commits on Jul 11, 2019
-
Multimedia requests seem to be working. Still testing edge cases.
jim committedJul 11, 2019 Configuration menu - View commit details
-
Copy full SHA for 3fbe927 - Browse repository at this point
Copy the full SHA 3fbe927View commit details
Commits on Jul 15, 2019
-
removed some logging, updated docs.
jim committedJul 15, 2019 Configuration menu - View commit details
-
Copy full SHA for 9e4b656 - Browse repository at this point
Copy the full SHA 9e4b656View commit details
Commits on Jul 26, 2019
-
buildig out for multiple requests
jim committedJul 26, 2019 Configuration menu - View commit details
-
Copy full SHA for d701b70 - Browse repository at this point
Copy the full SHA d701b70View commit details
Commits on Jul 30, 2019
-
jim committed
Jul 30, 2019 Configuration menu - View commit details
-
Copy full SHA for de9b3c2 - Browse repository at this point
Copy the full SHA de9b3c2View commit details -
dumped the idea of multiple appIds for an impresion.
jim committedJul 30, 2019 Configuration menu - View commit details
-
Copy full SHA for 92235e9 - Browse repository at this point
Copy the full SHA 92235e9View commit details
Commits on Jul 31, 2019
-
Changed the Video property to a slice and now sendig multiple video r…
…equests. Removed range calls from for loops. I asume that's faster.
jim committedJul 31, 2019 Configuration menu - View commit details
-
Copy full SHA for 6ab8f71 - Browse repository at this point
Copy the full SHA 6ab8f71View commit details -
jim committed
Jul 31, 2019 Configuration menu - View commit details
-
Copy full SHA for ec31df9 - Browse repository at this point
Copy the full SHA ec31df9View commit details -
Merge remote-tracking branch 'origin/master' into issue862
jim committedJul 31, 2019 Configuration menu - View commit details
-
Copy full SHA for 6e0e8c5 - Browse repository at this point
Copy the full SHA 6e0e8c5View commit details -
jim committed
Jul 31, 2019 Configuration menu - View commit details
-
Copy full SHA for 4c1d5aa - Browse repository at this point
Copy the full SHA 4c1d5aaView commit details -
jim committed
Jul 31, 2019 Configuration menu - View commit details
-
Copy full SHA for 45b3510 - Browse repository at this point
Copy the full SHA 45b3510View commit details
Commits on Aug 1, 2019
-
updated and expanded on test cases
jim committedAug 1, 2019 Configuration menu - View commit details
-
Copy full SHA for 210aed0 - Browse repository at this point
Copy the full SHA 210aed0View commit details -
jim committed
Aug 1, 2019 Configuration menu - View commit details
-
Copy full SHA for b8df0f3 - Browse repository at this point
Copy the full SHA b8df0f3View commit details -
jim committed
Aug 1, 2019 Configuration menu - View commit details
-
Copy full SHA for 5cc97ea - Browse repository at this point
Copy the full SHA 5cc97eaView commit details
Commits on Aug 7, 2019
-
jim committed
Aug 7, 2019 Configuration menu - View commit details
-
Copy full SHA for eddc960 - Browse repository at this point
Copy the full SHA eddc960View commit details -
I'll need to update the docs later
jim committedAug 7, 2019 Configuration menu - View commit details
-
Copy full SHA for d2371db - Browse repository at this point
Copy the full SHA d2371dbView commit details -
hopefullt this straightens out some weirdness with my Gopkg.lock.
jim committedAug 7, 2019 Configuration menu - View commit details
-
Copy full SHA for 52dc78d - Browse repository at this point
Copy the full SHA 52dc78dView commit details
Commits on Aug 8, 2019
-
jim committed
Aug 8, 2019 Configuration menu - View commit details
-
Copy full SHA for 3766f28 - Browse repository at this point
Copy the full SHA 3766f28View commit details
Commits on Aug 14, 2019
-
I don't see a way that r.Cur could be set, but covering it anyway
jim committedAug 14, 2019 Configuration menu - View commit details
-
Copy full SHA for 14ee1d2 - Browse repository at this point
Copy the full SHA 14ee1d2View commit details -
I'm only adding good Slots to the banner request.
jim committedAug 14, 2019 Configuration menu - View commit details
-
Copy full SHA for 62e77bb - Browse repository at this point
Copy the full SHA 62e77bbView commit details
Commits on Aug 15, 2019
-
jim committed
Aug 15, 2019 Configuration menu - View commit details
-
Copy full SHA for 2b39dcc - Browse repository at this point
Copy the full SHA 2b39dccView commit details -
gofmt fixed some indenting on some comments
jim committedAug 15, 2019 Configuration menu - View commit details
-
Copy full SHA for 5e405ac - Browse repository at this point
Copy the full SHA 5e405acView commit details -
This cleans up some in getVideoRequests.
jim committedAug 15, 2019 Configuration menu - View commit details
-
Copy full SHA for 53b7aea - Browse repository at this point
Copy the full SHA 53b7aeaView commit details -
jim committed
Aug 15, 2019 Configuration menu - View commit details
-
Copy full SHA for 4d5f42f - Browse repository at this point
Copy the full SHA 4d5f42fView commit details -
jim committed
Aug 15, 2019 Configuration menu - View commit details
-
Copy full SHA for 0ae4ac8 - Browse repository at this point
Copy the full SHA 0ae4ac8View commit details -
jim committed
Aug 15, 2019 Configuration menu - View commit details
-
Copy full SHA for 167e18c - Browse repository at this point
Copy the full SHA 167e18cView commit details
Commits on Aug 22, 2019
-
as per comments by @mansinahar, cleaned up some comments and looking …
…at reduced duplication in getVideoRequests / getBannerRequest
jim committedAug 22, 2019 Configuration menu - View commit details
-
Copy full SHA for 914bcaf - Browse repository at this point
Copy the full SHA 914bcafView commit details -
@mansinahar pointed out that I dont need to use the addHeaderIfNonEmp…
…ty method for the cookie, but also, since I don't need to send the cookie for a banner request, rearanged things a bit to save some bytes on that request.
jim committedAug 22, 2019 Configuration menu - View commit details
-
Copy full SHA for e093428 - Browse repository at this point
Copy the full SHA e093428View commit details -
Covered a few more very helpfull comments from @mansinahar
jim committedAug 22, 2019 Configuration menu - View commit details
-
Copy full SHA for 96a67d4 - Browse repository at this point
Copy the full SHA 96a67d4View commit details -
fixed possible errs overwrite in preprocess. Also, I'm seeing a bug i…
…n validation that I don't think is me. It seems like with mixed baner/video request, validation gets mixed up and sends video requests to banner endpoints and vis versa. When I run the exact same request (well, switching 'bidder' to 'beachfront') it works fine. For now I've puled the two 'mixed' validation tests out. I still have > 88% coverage. I'll dig deeper into this in a bit and if it looks like an actual bug in the validation system I'll report that.
jim committedAug 22, 2019 Configuration menu - View commit details
-
Copy full SHA for ea6ee2a - Browse repository at this point
Copy the full SHA ea6ee2aView commit details -
Worked out how to do the site part proper.
jim committedAug 22, 2019 Configuration menu - View commit details
-
Copy full SHA for fa2ce42 - Browse repository at this point
Copy the full SHA fa2ce42View commit details -
Improved readability on video size
jim committedAug 22, 2019 Configuration menu - View commit details
-
Copy full SHA for e05e044 - Browse repository at this point
Copy the full SHA e05e044View commit details -
Improved the domain stuff a bit
jim committedAug 22, 2019 Configuration menu - View commit details
-
Copy full SHA for 38a0127 - Browse repository at this point
Copy the full SHA 38a0127View commit details -
Modified video to not append until the end
jim committedAug 22, 2019 Configuration menu - View commit details
-
Copy full SHA for fef4920 - Browse repository at this point
Copy the full SHA fef4920View commit details -
corrected some bugs in test cases
jim committedAug 22, 2019 Configuration menu - View commit details
-
Copy full SHA for cc8776f - Browse repository at this point
Copy the full SHA cc8776fView commit details
Commits on Aug 23, 2019
-
Addressed another round of comments and pointers from mansinahar
jim committedAug 23, 2019 Configuration menu - View commit details
-
Copy full SHA for ecfcc76 - Browse repository at this point
Copy the full SHA ecfcc76View commit details -
Found the source of the panic I was seeing when I tried to move the .…
…..reqs = make... line in MakeRequests. I was appending to a already sized slice, so winding up with a bunch of empty adapter.RequestData items.
jim committedAug 23, 2019 Configuration menu - View commit details
-
Copy full SHA for 1610fef - Browse repository at this point
Copy the full SHA 1610fefView commit details -
jim committed
Aug 23, 2019 Configuration menu - View commit details
-
Copy full SHA for c31f79d - Browse repository at this point
Copy the full SHA c31f79dView commit details -
Uhg. Trying to do two things at one leads to dumb mistakes.
jim committedAug 23, 2019 Configuration menu - View commit details
-
Copy full SHA for 5ac6e39 - Browse repository at this point
Copy the full SHA 5ac6e39View commit details -
jim committed
Aug 23, 2019 Configuration menu - View commit details
-
Copy full SHA for 7bb0db2 - Browse repository at this point
Copy the full SHA 7bb0db2View commit details
Commits on Aug 27, 2019
-
added slightly improved error reporting. I was running into errors wi…
…th test cases that didn't make sense to me - on multi-video.json. I was getting 2 errors when I ran validation, but none when I ran the same request from postman and stepped through in a debugging build. I need to look at that and at the. On unmarshal-error-video.json, I was getting a request sent with empty appId. I even added a check for it to bail right at the end, but the test system was still saying it would get through, and I don't see any way that is possible in a real request. Validation of the Ext object would stop it IRL. I'll look into this further. I do like test cases, but these don't seem to be reflecting reality.
jim committedAug 27, 2019 Configuration menu - View commit details
-
Copy full SHA for 69790a3 - Browse repository at this point
Copy the full SHA 69790a3View commit details -
jim committed
Aug 27, 2019 Configuration menu - View commit details
-
Copy full SHA for 3174bdb - Browse repository at this point
Copy the full SHA 3174bdbView commit details
Commits on Aug 28, 2019
-
jim committed
Aug 28, 2019 Configuration menu - View commit details
-
Copy full SHA for bcc3734 - Browse repository at this point
Copy the full SHA bcc3734View commit details -
fixed all the references in test cases for version bump
jim committedAug 28, 2019 Configuration menu - View commit details
-
Copy full SHA for 6b32fd8 - Browse repository at this point
Copy the full SHA 6b32fd8View commit details -
found the source of the panic on multi - mix test. Some flawed logic …
…in keeping the indexes straight in MakeRequests. I've added back a couple of test cases, which now pass.
jim committedAug 28, 2019 Configuration menu - View commit details
-
Copy full SHA for d63ecfa - Browse repository at this point
Copy the full SHA d63ecfaView commit details
Commits on Sep 5, 2019
-
I needed a status in my mock response for multi-video test case.
jim committedSep 5, 2019 Configuration menu - View commit details
-
Copy full SHA for 53915ce - Browse repository at this point
Copy the full SHA 53915ceView commit details -
this gets the unmarshal-error-video.json test case working. The probl…
…em was that an empty adapters.RequestData was being added. Also added test case unmarshal-error-but-another-good-video.json, which throws and tracks the unmarshal error and dumps that bad one, then adds and requests the good video imp.
jim committedSep 5, 2019 Configuration menu - View commit details
-
Copy full SHA for 60f2c73 - Browse repository at this point
Copy the full SHA 60f2c73View commit details