Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue862 - implemented multi media bids #993

Closed
wants to merge 49 commits into from
Closed

Issue862 - implemented multi media bids #993

wants to merge 49 commits into from

Commits on Jul 1, 2019

  1. looking into issue 862

    jim committed Jul 1, 2019
    Configuration menu
    Copy the full SHA
    e9fa33d View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2019

  1. Configuration menu
    Copy the full SHA
    58e10da View commit details
    Browse the repository at this point in the history
  2. Improved handling of imps that are looking for both banner and video.…

    … This requires using aliases. Updated the documentation and similar to descrbe that.
    jim committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    9975473 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2019

  1. Configuration menu
    Copy the full SHA
    3fbe927 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2019

  1. removed some logging, updated docs.

    jim committed Jul 15, 2019
    Configuration menu
    Copy the full SHA
    9e4b656 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2019

  1. buildig out for multiple requests

    jim committed Jul 26, 2019
    Configuration menu
    Copy the full SHA
    d701b70 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2019

  1. not progress at stacking it.

    jim committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    de9b3c2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    92235e9 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2019

  1. Changed the Video property to a slice and now sendig multiple video r…

    …equests. Removed range calls from for loops. I asume that's faster.
    jim committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    6ab8f71 View commit details
    Browse the repository at this point in the history
  2. cleaning up a bit

    jim committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    ec31df9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6e0e8c5 View commit details
    Browse the repository at this point in the history
  4. corrected some access levels

    jim committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    4c1d5aa View commit details
    Browse the repository at this point in the history
  5. removed redundant counters

    jim committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    45b3510 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2019

  1. updated and expanded on test cases

    jim committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    210aed0 View commit details
    Browse the repository at this point in the history
  2. deleted my debug build

    jim committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    b8df0f3 View commit details
    Browse the repository at this point in the history
  3. cleaning up a bit

    jim committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    5cc97ea View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2019

  1. mior fix to error output

    jim committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    eddc960 View commit details
    Browse the repository at this point in the history
  2. I'll need to update the docs later

    jim committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    d2371db View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    52dc78d View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2019

  1. corrected an indexing bug

    jim committed Aug 8, 2019
    Configuration menu
    Copy the full SHA
    3766f28 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2019

  1. Configuration menu
    Copy the full SHA
    14ee1d2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    62e77bb View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2019

  1. removed my test error

    jim committed Aug 15, 2019
    Configuration menu
    Copy the full SHA
    2b39dcc View commit details
    Browse the repository at this point in the history
  2. gofmt fixed some indenting on some comments

    jim committed Aug 15, 2019
    Configuration menu
    Copy the full SHA
    5e405ac View commit details
    Browse the repository at this point in the history
  3. This cleans up some in getVideoRequests.

    jim committed Aug 15, 2019
    Configuration menu
    Copy the full SHA
    53b7aea View commit details
    Browse the repository at this point in the history
  4. removed inaccurate comment

    jim committed Aug 15, 2019
    Configuration menu
    Copy the full SHA
    4d5f42f View commit details
    Browse the repository at this point in the history
  5. removed test error

    jim committed Aug 15, 2019
    Configuration menu
    Copy the full SHA
    0ae4ac8 View commit details
    Browse the repository at this point in the history
  6. gofmted

    jim committed Aug 15, 2019
    Configuration menu
    Copy the full SHA
    167e18c View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2019

  1. as per comments by @mansinahar, cleaned up some comments and looking …

    …at reduced duplication in getVideoRequests / getBannerRequest
    jim committed Aug 22, 2019
    Configuration menu
    Copy the full SHA
    914bcaf View commit details
    Browse the repository at this point in the history
  2. @mansinahar pointed out that I dont need to use the addHeaderIfNonEmp…

    …ty method for the cookie, but also, since I don't need to send the cookie for a banner request, rearanged things a bit to save some bytes on that request.
    jim committed Aug 22, 2019
    Configuration menu
    Copy the full SHA
    e093428 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    96a67d4 View commit details
    Browse the repository at this point in the history
  4. fixed possible errs overwrite in preprocess. Also, I'm seeing a bug i…

    …n validation that I don't think is me. It seems like with mixed baner/video request, validation gets mixed up and sends video requests to banner endpoints and vis versa. When I run the exact same request (well, switching 'bidder' to 'beachfront') it works fine. For now I've puled the two 'mixed' validation tests out. I still have > 88% coverage. I'll dig deeper into this in a bit and if it looks like an actual bug in the validation system I'll report that.
    jim committed Aug 22, 2019
    Configuration menu
    Copy the full SHA
    ea6ee2a View commit details
    Browse the repository at this point in the history
  5. Worked out how to do the site part proper.

    jim committed Aug 22, 2019
    Configuration menu
    Copy the full SHA
    fa2ce42 View commit details
    Browse the repository at this point in the history
  6. Improved readability on video size

    jim committed Aug 22, 2019
    Configuration menu
    Copy the full SHA
    e05e044 View commit details
    Browse the repository at this point in the history
  7. Improved the domain stuff a bit

    jim committed Aug 22, 2019
    Configuration menu
    Copy the full SHA
    38a0127 View commit details
    Browse the repository at this point in the history
  8. Modified video to not append until the end

    jim committed Aug 22, 2019
    Configuration menu
    Copy the full SHA
    fef4920 View commit details
    Browse the repository at this point in the history
  9. corrected some bugs in test cases

    jim committed Aug 22, 2019
    Configuration menu
    Copy the full SHA
    cc8776f View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2019

  1. Configuration menu
    Copy the full SHA
    ecfcc76 View commit details
    Browse the repository at this point in the history
  2. Found the source of the panic I was seeing when I tried to move the .…

    …..reqs = make... line in MakeRequests. I was appending to a already sized slice, so winding up with a bunch of empty adapter.RequestData items.
    jim committed Aug 23, 2019
    Configuration menu
    Copy the full SHA
    1610fef View commit details
    Browse the repository at this point in the history
  3. quick fix in a test case

    jim committed Aug 23, 2019
    Configuration menu
    Copy the full SHA
    c31f79d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5ac6e39 View commit details
    Browse the repository at this point in the history
  5. improved a test case

    jim committed Aug 23, 2019
    Configuration menu
    Copy the full SHA
    7bb0db2 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2019

  1. added slightly improved error reporting. I was running into errors wi…

    …th test cases that didn't make sense to me - on multi-video.json. I was getting 2 errors when I ran validation, but none when I ran the same request from postman and stepped through in a debugging build. I need to look at that and at the. On unmarshal-error-video.json, I was getting a request sent with empty appId. I even added a check for it to bail right at the end, but the test system was still saying it would get through, and I don't see any way that is possible in a real request. Validation of the Ext object would stop it IRL. I'll look into this further. I do like test cases, but these don't seem to be reflecting reality.
    jim committed Aug 27, 2019
    Configuration menu
    Copy the full SHA
    69790a3 View commit details
    Browse the repository at this point in the history
  2. eliminated a redundant else

    jim committed Aug 27, 2019
    Configuration menu
    Copy the full SHA
    3174bdb View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2019

  1. A version bump

    jim committed Aug 28, 2019
    Configuration menu
    Copy the full SHA
    bcc3734 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6b32fd8 View commit details
    Browse the repository at this point in the history
  3. found the source of the panic on multi - mix test. Some flawed logic …

    …in keeping the indexes straight in MakeRequests. I've added back a couple of test cases, which now pass.
    jim committed Aug 28, 2019
    Configuration menu
    Copy the full SHA
    d63ecfa View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2019

  1. Configuration menu
    Copy the full SHA
    53915ce View commit details
    Browse the repository at this point in the history
  2. this gets the unmarshal-error-video.json test case working. The probl…

    …em was that an empty adapters.RequestData was being added. Also added test case unmarshal-error-but-another-good-video.json, which throws and tracks the unmarshal error and dumps that bad one, then adds and requests the good video imp.
    jim committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    60f2c73 View commit details
    Browse the repository at this point in the history