native tracker manager click tracker not firing #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…html element inside <a> tag
|
@wqi1972 - is this PR needed even if we implement the improvements to native as noted in prebid/Prebid.js#5149? |
|
@bretg we won't need this PR after prebid/Prebid.js#5149. Inside prebid/Prebid.js#5149 it will fundamentally solve this problem, since new implement will pass adId as parameter, there will be no need to read adId from html element anymore. If we have some Universal creative release before prebid/Prebid.js#5149 get implemented, I suggest we merge this PR into it, since this bug already impacts some publishers (#88). If we don't, then we can close this PR and wait for prebid/Prebid.js#5149 solve it fundamentally. |
robertrmartinez
approved these changes
Jun 4, 2020
jsnellbaker
approved these changes
Jun 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor code inside
attachClickListeners, so that it read adId from the<a>tag element instead of read it fromevent.target.Code read from
event.targethas trouble when there is inner tag inside<a>tag, for example:<a href="%%CLICK_URL_UNESC%%%%PATTERN:hb_native_linkurl%%" target="_blank" class="pb-click" pbAdId="%%PATTERN:hb_adid%%"><p>%%PATTERN:hb_native_title%%<p></a>when click event fires, the
<p>tag is the event.target, not<a>tag, in that case, original code inside function readAdIdFromEvent won't work.Adjusted test case for it as well.