-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Module fledgeForGpt: Document AuctionConfig fields #5128
Comments
The The authority on To me, the differences noted above show a good reason why incorporating the AuctionConfig specification in the fledgeForGpt documentation in any way other than by reference is likely to result in yet another lagging spec to foster confusion. Maybe at this time it's more beneficial to have many pointers to one authoritative spec than many copies with varying degrees of fidelity to it. |
Thanks for confirming that the GTP spec lags, we'll follow the FLEDGE/WICG spec :) I agree to not duplicate yet another doc and risk it getting outdated If Prebid can guarantee the module will always be in sync with the FLEDGE doc, we can work with that |
fwiw the right hand part of the chart is not valid for the component seller, as there are no sub-components |
@maxime-dupuis - there's a new version of this page at #5135 - please take a look at the preview if you have a few mins to see if it addresses your concerns. |
@bretg I do like the new structure and how you separated the But to answer your question, as a bid adapter maintainer, it neither improves nor worsen my understanding about the shape of the AuctionConfig object.
Even if it did, the PAAPI doc is just a big confusing wall of text. (I don't expect Prebid to fix that, that one is on Google) |
So what exactly do you mean by this @maxime-dupuis ? If you're looking for "which fields should I specify in my auctionconfig", that's not for Prebid to decide or document. If you're looking for "does Prebid care what fields are in the auction config", the answer is clearly If you're looking for "does Prebid add anything to auctionconfig", I believe the answer is yes, Prebid.js adds a "bidfloor" to the auctionconfig since I see |
"which fields should I specify in my auctionconfig"
I understand and agree. I propose that Prebid should link to the external documentation |
Cool, but link to where? The PR already has several links to https://github.com/WICG/turtledove/blob/main/FLEDGE.md -- are you suggesting that since it's such a large doc, that linking to https://github.com/WICG/turtledove/blob/main/FLEDGE.md#21-initiating-an-on-device-auction might be useful? With what text -- something like "Prebid can't tell you what fields to include in auctionconfig, but you can start by looking in this section of the PAAPI documentation." |
Right on! That would be great |
Ok, updated the PR with this note. Thanks. |
* Prebid.js: new PAAPI module documentation * remove references to reuse * feedback * Update paapi.md * Update paapi.md * added auctionconfig note from #5128 --------- Co-authored-by: bretg <bgorsline@gmail.com>
FledgeForGpt module being the API between bidder adapters and GPT, I think this documentation would be improved by explicitly documenting the supported AuctionConfig fields:
Currently it's unclear to me
Here's a diff of the fields between the 2 documentations:
The text was updated successfully, but these errors were encountered: