update to s2sconfig properties notes #1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaiminpanchal27
requested changes
Nov 16, 2018
jeanstemp
suggested changes
Nov 16, 2018
dev-docs/publisher-api-reference.md
Outdated
|
|
||
| - Currently supported vendors are: appnexus & rubicon | ||
| - When using `defaultVendor` option, `accountId` and `bidders` properties still need to be defined. | ||
| - If `timeout` is larger than Prebid.js timeout, this timeout will be automatically adjusted to 75% of the Prebid.js's timeout in order to have it fit within the auction process. |
There was a problem hiding this comment.
Suggested rewording to clarify:
If the s2sConfig timeout is greater than the Prebid.js timeout, the s2sConfig timeout will be automatically adjusted to 75% of the Prebid.js timeout in order to fit within the auction process.
There was a problem hiding this comment.
Thanks for the feedback; made the requested changes.
jeanstemp
approved these changes
Nov 16, 2018
jaiminpanchal27
approved these changes
Dec 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs for this Prebid.js change:
prebid/Prebid.js#3291
Also changed the formatting around this section to make it a proper bullet list.