Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long form doc updates #1193

Merged
merged 4 commits into from
Mar 6, 2019
Merged

Long form doc updates #1193

merged 4 commits into from
Mar 6, 2019

Conversation

jaiminpanchal27
Copy link
Collaborator

Fixed api typos, code blocks, added tables and updated description at some places

Copy link
Collaborator

@MartianTribe MartianTribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dev-docs/modules/freewheel.md

dev-docs/modules/freewheel.md Outdated Show resolved Hide resolved
dev-docs/modules/categoryTranslation.md Outdated Show resolved Hide resolved
dev-docs/modules/categoryTranslation.md Outdated Show resolved Hide resolved
@MartianTribe
Copy link
Collaborator

If you have changed the file name to categoryTranslation for the IAB Category Translation module make sure all the links to that file also get updated.

@jaiminpanchal27
Copy link
Collaborator Author

@MartianTribe Changes done. I updated the links in my initial commit.

Copy link
Contributor

@jeanstemp jeanstemp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaiminpanchal27 Thanks so much for going over all of this. I noted just a few minor things to fix.

dev-docs/bidder-adaptor.md Outdated Show resolved Hide resolved
dev-docs/bidder-adaptor.md Outdated Show resolved Hide resolved
dev-docs/publisher-api-reference.md Outdated Show resolved Hide resolved
@jaiminpanchal27
Copy link
Collaborator Author

@jeanstemp Thanks for review. Addressed all the feedback.

@jaiminpanchal27 jaiminpanchal27 merged commit 5be35dc into master Mar 6, 2019
@muuki88 muuki88 deleted the longform-fixes branch October 5, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants