Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pb amp docs #1212

Merged
merged 7 commits into from
Mar 25, 2019
Merged

Pb amp docs #1212

merged 7 commits into from
Mar 25, 2019

Conversation

MartianTribe
Copy link
Collaborator

Added error messages and reformatted document to be more in line with publisher's API.

jeanstemp
jeanstemp suggested changes Mar 19, 2019
View reviewed changes
Copy link
Contributor

@jeanstemp jeanstemp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the Request example, the comment "The sizes are defined is set..." doesn't sound right, can you fix that?

Under "Query Parameters," is there a better place to link them to for info than a PR?

prebid-server/endpoints/openrtb2/amp.md Outdated Show resolved Hide resolved
prebid-server/endpoints/openrtb2/amp.md Outdated Show resolved Hide resolved
prebid-server/endpoints/openrtb2/amp.md Outdated Show resolved Hide resolved
prebid-server/endpoints/openrtb2/amp.md Outdated Show resolved Hide resolved
prebid-server/endpoints/openrtb2/amp.md Outdated Show resolved Hide resolved
prebid-server/endpoints/openrtb2/amp.md Outdated Show resolved Hide resolved
@MartianTribe MartianTribe requested a review from bretg March 22, 2019 17:21
jeanstemp
jeanstemp approved these changes Mar 22, 2019
View reviewed changes
Copy link
Contributor

@jeanstemp jeanstemp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the additional info!

@MartianTribe MartianTribe merged commit 93d244a into master Mar 25, 2019
@MartianTribe MartianTribe deleted the pb-amp-docs branch April 22, 2019 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanstemp jeanstemp jeanstemp approved these changes

@hhhjort hhhjort Awaiting requested review from hhhjort

@bretg bretg Awaiting requested review from bretg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MartianTribe @jeanstemp