Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit doc custom keywords #1224

Closed
wants to merge 2 commits into from
Closed

Edit doc custom keywords #1224

wants to merge 2 commits into from

Conversation

AntoineJac
Copy link
Contributor

No description provided.

Antoine Jacquemin (Rubicon) added 2 commits March 26, 2019 14:50
@bretg
Copy link
Contributor

bretg commented Mar 26, 2019

Thanks @AntoineJac -- would like to align this with the proposal at prebid/Prebid.js#3687

i.e. instead of

TargetingParams.addUserKeyword(key: "testUserKey", value: "testUserValue")
TargetingParams.addInvKeyword("my_key_inv", "my_value_inv");

it would be something like

TargetingParams.addUserData(key: "testUserKey", value: "testUserValue")
TargetingParams.addContextData(key: "testContext", value: "testContextValue")
TargetingParams.addKeywords(["mykw1", "mykw2"]);

@bretg
Copy link
Contributor

bretg commented Apr 4, 2019

@AntoineJac - is this PR still good considering the changes proposed for first party data in prebid/Prebid.js#3687 ?

@AntoineJac
Copy link
Contributor Author

@bretg , not yet I will work on it this week or next week following the changes proposed by prebid/Prebid.js#3687

@AntoineJac
Copy link
Contributor Author

Close this one as it will be know using context and user data!

@AntoineJac AntoineJac closed this May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants