Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create edgequeryx.md #1962

Merged
merged 5 commits into from
May 27, 2020
Merged

Create edgequeryx.md #1962

merged 5 commits into from
May 27, 2020

Conversation

edgequery
Copy link
Contributor

No description provided.

@jeanstemp
Copy link
Contributor

@edgequery Can you add a link in the comments to the PBJS PR that this is associated with? Thanks!

@edgequery
Copy link
Contributor Author

@MartianTribe
Copy link
Collaborator

Hi, I think there has been some confusion on our process. Your edgequertxBidAdapter.js file should be submitted as a PR to:

Prebid.js

This repo is just for docs. Could you delete the .js from this PR. If there is a corresponding PR or when you create one on Prebid.js for the adapter, add a link to it in this PR.

You can review this PR as an example:

#1963

@edgequery
Copy link
Contributor Author

Hello,

I can't create a PR to Prebid.js:
remote: Permission to prebid/Prebid.js.git denied to edgequery.
fatal: unable to access 'https://github.com/prebid/Prebid.js.git/': The requested URL returned error: 403

So a put js files on my own repro:
https://github.com/edgequery/prebid

Thanks for your help.

@MartianTribe
Copy link
Collaborator

I forwarded your issue to the people in charge of our github site. I'm not sure if the code sitting outside prebid.js' github will work for including it in our build. Someone will get back to you and we'll find a solution.

@jeanstemp @bretg

@bretg
Copy link
Contributor

bretg commented May 12, 2020

I can't create a PR to Prebid.js: remote: Permission to prebid/Prebid.js.git denied to edgequery.

You need to fork the Prebid.js repo, branch for your feature/update, and submit the PR from your forked branch. After review, that code will get merged into the master repo.

@edgequery
Copy link
Contributor Author

Sorry for all of that, now it's all right.
The PR of the fork : prebid/Prebid.js#5221

@edgequery
Copy link
Contributor Author

Sorry the right PR is : prebid/Prebid.js#5224

@edgequery
Copy link
Contributor Author

Hello,
Here you will find the latest PR with Test Units :
prebid/Prebid.js#5256

@edgequery
Copy link
Contributor Author

@aleksatr Hello, the PR with a MD file and not MB :-)

prebid/Prebid.js#5266

@edgequery
Copy link
Contributor Author

Hello,

The last PR was merged in Prebid.js, when will be Edge Query Adapter available on website ?

@bretg
Copy link
Contributor

bretg commented May 23, 2020

We don't merge the docs PR until the Prebid.js code is released. The code PR is in 3.21, so after that's released, this will be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants