Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floors Module: new analytics fields #2013

Merged
merged 2 commits into from
May 27, 2020
Merged

Floors Module: new analytics fields #2013

merged 2 commits into from
May 27, 2020

Conversation

bszekely1
Copy link
Contributor

Added a fetchStatus field in the analytics interface.

@Fawke
Copy link
Contributor

Fawke commented May 27, 2020

@bszekely1 I noticed that we added a new signal, skipRate along with fetchStatus, but I found it missing in this change. Should we document it as well?

@bszekely1
Copy link
Contributor Author

yes, skipRate should be added as well. Updated PR.

@bszekely1 bszekely1 merged commit 2c7c64f into master May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants