Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding userId to smartadserver.md #2062

Merged
merged 4 commits into from
Jun 26, 2020
Merged

Conversation

lowendavid
Copy link
Contributor

Added the userId to the documentation.
Minor cleanup

Added the userId to the documentation.
Copy link
Collaborator

@smenzer smenzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

userId docs should be at the top, not in the bid params table

dev-docs/bidders/smartadserver.md Outdated Show resolved Hide resolved
dev-docs/bidders/smartadserver.md Outdated Show resolved Hide resolved
lowendavid and others added 2 commits June 17, 2020 08:18
this should be userIds rather than eids_supported

Co-authored-by: Scott <smenzer@gmail.com>
This should not be with the bidder paramters and therefore should be moved out.

Co-authored-by: Scott <smenzer@gmail.com>
@lowendavid lowendavid mentioned this pull request Jun 18, 2020
1 task
Copy link
Collaborator

@smenzer smenzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeanstemp
Copy link
Contributor

@lowendavid This PR wound up with merge conflicts. Please fix them and I'll merge the PR.

@jeanstemp jeanstemp merged commit 6e724cc into prebid:master Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants