Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undertone video docs #2162

Merged
merged 5 commits into from
Aug 5, 2020
Merged

Undertone video docs #2162

merged 5 commits into from
Aug 5, 2020

Conversation

oranperion
Copy link
Contributor

No description provided.

omerko and others added 5 commits June 18, 2019 13:08
Added documentation for recommended configuration settings for undertone which includes iframe based user sync
@jeanstemp
Copy link
Contributor

@oranperion Is this a change to match this PR from last week? https://github.com/prebid/Prebid.js/pull/5485/files ?

What about playerSize and streamType, should those be included here?

Also, I'm not sure what all the extra bot comments and merges from a few years ago are? But the one file that's showing as changed looks good, other than my question about those other params that I see in the PBJS PR.

@oranperion
Copy link
Contributor Author

hi @jeanstemp , yes this is the documentation update for the pull request https://github.com/prebid/Prebid.js/pull/5485/files
regarding the playerSize and streamType - those are been taken from the ad unit parameters which are common to all bidders, so i didn't include those here as its not unique to undertone only (same as other bidders like appnexus)

@MartianTribe MartianTribe merged commit 347867c into prebid:master Aug 5, 2020
bretg added a commit that referenced this pull request Aug 12, 2020
* Privacy updates (#2189)

* privacy notice: updates from legal review

* download page legal notice

* review changes

* pubperf analytics adapter added. (#2166)

* Add docs for apstream adapter (#2141)

* Add docs for apstream adapter

* Describe possibility to disable DSU

Co-authored-by: Yevhenii Tykhostup <yevhenii.tykhostup@audienceproject.com>

* AdButler Bid Adapter: Add 'extra' bid parameter description and example (#2172)

* Undertone video docs (#2162)

* Update undertone.md

Added documentation for recommended configuration settings for undertone which includes iframe based user sync

* add video object doc

Co-authored-by: Omer Koren <omerko@users.noreply.github.com>

* ad ops video fix (#2190)

* clarifying that sizeConfig is banner only (#2191)

* amp clarification (#2194)

* removed stray div

* removing apn-specific reference (#2203)

* added akamai video player (#2181)

Co-authored-by: Steve <ssuranie@appnexus.com>

* removing pubcommon support from Rubicon (#2211)

* adding concurrent FAQ entry (#2212)

* fixed typo in pbadslot example (#2213)

* pbadslot implementation ended up moving the location (#2214)

* Update CNAME

Co-authored-by: Bruce Dou <doubaokun@gmail.com>
Co-authored-by: frstua <moyade@gmail.com>
Co-authored-by: Yevhenii Tykhostup <yevhenii.tykhostup@audienceproject.com>
Co-authored-by: Dan Harton <dan@sparklit.com>
Co-authored-by: Oran Hollaender <oran@perion.com>
Co-authored-by: Omer Koren <omerko@users.noreply.github.com>
Co-authored-by: MartianTribe <steve@martiantribe.com>
Co-authored-by: Steve <ssuranie@appnexus.com>
K-JBoon added a commit to bluebillywig/prebid.github.io that referenced this pull request Apr 7, 2021
* 'master' of github.com:bluebillywig/prebid.github.io: (150 commits)
  move empty line to right place...
  Add missing empty line
  add Blue Billywig bidder adaptor dev docs
  removed stray div
  amp clarification (prebid#2194)
  clarifying that sizeConfig is banner only (prebid#2191)
  ad ops video fix (prebid#2190)
  Undertone video docs (prebid#2162)
  AdButler Bid Adapter: Add 'extra' bid parameter description and example (prebid#2172)
  Add docs for apstream adapter (prebid#2141)
  pubperf analytics adapter added. (prebid#2166)
  Privacy updates (prebid#2189)
  adding aug 2020 event (prebid#2183)
  Update adtelligent doc (prebid#2173)
  TCF2 Support (prebid#2176)
  added yieldlab and konduit to members page (prebid#2177)
  add GPT pre-auction module to Modules sidebar (prebid#2174)
  Gpt pre auction docs (prebid#2168)
  Floors Module: added Floors Provider (prebid#2169)
  Update doc file for TheMediaGrid Bid Adapter (prebid#2167)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants