Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "theAdx" capitalization issue #2243

Merged
merged 2 commits into from
Aug 19, 2020
Merged

Fix "theAdx" capitalization issue #2243

merged 2 commits into from
Aug 19, 2020

Conversation

ian-lr
Copy link
Contributor

@ian-lr ian-lr commented Aug 17, 2020

A publisher reported an error with the prebid.js package when including a bidder from theAdx. This appears to be a capitalization issue -- the file name itself is theAdxBidAdapter.js but theadx.md has a bidder code of theadx which is then parsed in download.md as theadxBidAdapter.js, leading to a build issue ("error":"Prebid file not built properly").

theAdxBidAdapter.js != theadxBidAdapter.js

This addresses that specific capitalization issue, but perhaps we should modify download.md to downcase all bidder code inputs to avoid case-sensitivity issues.

If the reviewer agrees, I'll try to get a PR that will handle case issues going forward.

@bretg
Copy link
Contributor

bretg commented Aug 19, 2020

Thanks @ian-lr - I'm not a fan of making a generic change here. The Download system is more than a page -- it's a build system running on AWS. I don't want any differences between a standard Prebid.js command-line build and what's done on the Download build server.

Any solution would have to come in the Prebid.js build itself. If that were case insensitive, the general issue would be solved.

@bretg bretg merged commit 9d95824 into prebid:master Aug 19, 2020
@bretg
Copy link
Contributor

bretg commented Aug 19, 2020

Ugh - realized that I got the conflict resolution wrong here -- re-did this fix in #2257

@bretg
Copy link
Contributor

bretg commented Aug 19, 2020

Confirmed it downloads now

@ian-lr
Copy link
Contributor Author

ian-lr commented Aug 19, 2020

Thanks @ian-lr - I'm not a fan of making a generic change here. The Download system is more than a page -- it's a build system running on AWS. I don't want any differences between a standard Prebid.js command-line build and what's done on the Download build server.

Any solution would have to come in the Prebid.js build itself. If that were case insensitive, the general issue would be solved.

@bretg I got you -- that makes sense. I haven't looked into the build system itself yet but let me see if there's an easy fix (at my level of expertise).

@ian-lr ian-lr deleted the theadx-fix branch August 19, 2020 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants