Fix "theAdx" capitalization issue #2243
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A publisher reported an error with the prebid.js package when including a bidder from
theAdx
. This appears to be a capitalization issue -- the file name itself istheAdxBidAdapter.js
buttheadx.md
has a bidder code oftheadx
which is then parsed indownload.md
astheadxBidAdapter.js
, leading to a build issue ("error":"Prebid file not built properly"
).theAdxBidAdapter.js
!=theadxBidAdapter.js
This addresses that specific capitalization issue, but perhaps we should modify
download.md
to downcase all bidder code inputs to avoid case-sensitivity issues.If the reviewer agrees, I'll try to get a PR that will handle case issues going forward.