include a renderer for a specific mediaType #2343
Conversation
pull in updates from prebid
|
fixed conflicts |
dev-docs/show-outstream-video-ads.md
Outdated
| 1. If a `renderer` is associated with the Prebid adUnit, it will be used to display any outstream demand associated with that adUnit. Below, we will provide an example of an adUnit with an associated `renderer`. If that renderer is specified as backup only, it will only be used when no other renderer is found. | ||
| 2. If no `renderer` is specified on the Prebid adUnit, Prebid will invoke the renderer associated with the winning (or selected) demand partner video bid. Choosing a backup only renderer allows publishers to access demand with or without an attached renderer. | ||
| 1. If a `renderer` is associated with the Prebid adUnit's video mediaType, it will be used to display any outstream demand associated with that adUnit with a mediaType of "video". | ||
| 2. If a `renderer` is associated with the Prebid adUnit, it will be used to display any outstream demand associated with that adUnit. Below, we will provide an example of an adUnit with an associated `renderer`. |
There was a problem hiding this comment.
I would again remove the word outstream here, and perhaps indicate that the url would be invoked regardless of mediaType. Also, I think it makes sense to say this is legacy and #1 is now the preferred way.
dev-docs/show-outstream-video-ads.md
Outdated
| @@ -67,13 +65,16 @@ To display an outstream video, two things are needed: | |||
|
|
|||
| Prebid.js will select the `renderer` used to display the outstream video in the following way: | |||
|
|
|||
| 1. If a `renderer` is associated with the Prebid adUnit, it will be used to display any outstream demand associated with that adUnit. Below, we will provide an example of an adUnit with an associated `renderer`. If that renderer is specified as backup only, it will only be used when no other renderer is found. | |||
| 2. If no `renderer` is specified on the Prebid adUnit, Prebid will invoke the renderer associated with the winning (or selected) demand partner video bid. Choosing a backup only renderer allows publishers to access demand with or without an attached renderer. | |||
| 1. If a `renderer` is associated with the Prebid adUnit's video mediaType, it will be used to display any outstream demand associated with that adUnit with a mediaType of "video". | |||
There was a problem hiding this comment.
I would remove the word outstream here
There was a problem hiding this comment.
@patmmccann - this document is called "Show Outstream Video Ads", so one argument is that this page should be focused on that use case.
Perhaps that implies we need a new page that focuses on "Multiformat Renderer" support?
| code: 'video1', | ||
| // This renderer would work the same as it does above... | ||
| renderer: { | ||
| url: 'example.com/publishersCustomRenderer.js', |
There was a problem hiding this comment.
i think we should make this an example of the new "preferred" way and remove this altogether? what do you think
There was a problem hiding this comment.
also I would change line 171 to refer to your pull request, 5760
|
I think we should leave this doc outstream focused and create a new doc. Opened issue #2465 to track. The new doc may not be done in time for PBJS release tomorrow. |
|
Seems reasonable to me, thanks!
…On Tue, Nov 3, 2020, 5:27 PM bretg ***@***.***> wrote:
I think we should leave this doc outstream focused and create a new doc.
Opened issue #2465
<#2465> to track. The
new doc may not be done in time for PBJS release tomorrow.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2343 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAM25Z3WMU4HA5Y3JSOCV3LSOB7WXANCNFSM4RPFA2AA>
.
|
|
Sorry to leave this open for so long! I am able to make any changes today. I agree on a separate page for multiFormat renderers, because both my change and the recent change to allow for a backup renderer can apply to all formats. I can make the changes for this ticket today, and I can start work on #2465 To close this ticket, it looks like I should leave any "outstream" language, but still make the changes to
|
|
Thanks Mike!
…On Wed, Nov 4, 2020, 11:06 AM Mike Sperone ***@***.***> wrote:
Sorry to leave this open for so long! I am able to make any changes today.
I agree on a separate page for multiFormat renderers, because both my
change and the recent change to allow for a backup renderer can apply to
all formats.
I can make the changes for this ticket today, and I can start work on
#2465 <#2465>
To close this ticket, it looks like I should leave any "outstream"
language, but still make the changes to
- show that ex. number 1 is the preferred way
- and refer to pull request 5760 in line 171
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2343 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAM25Z5KMG2Q22UYVBUJS4DSOF3W5ANCNFSM4RPFA2AA>
.
|
Documentation now states that applying the renderer property to the
mediaType property ('video' in this page) is preferred to applying it
on the adUnit level. The example code also shows this.
Also refers to the pull request where this change was made.
Documentation describing the new changes in a PR to address this issue:
prebid/Prebid.js#3231
A publisher can define a renderer for a specific mediaType - example, defining just a video renderer, so that a display can render with its own, or a separately defined renderer.