-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Audigent RTD provider Docs #2369
Conversation
@bretg thanks for the feedback, addressing these issues |
@bretg we're going to extend our RTD module to modify bid requests for individual bid adapters generically so that individual bid adapters do not require modification. i'm going to submit another PR to Prebid main and update the docs here once that is completed. |
Updated Prebid.js PR prebid/Prebid.js#5903 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I'm understanding it correctly, this module is supplying First Party Data without using the appropriate FPD conventions.
I dislike the "bidSegmentMappers" design here -- first publishers shouldn't have to do this and secondly, it's perpetuating bidder-specific FPD.
I'm willing to let this happen for a transition period, but expect to see it evolve to use the appropriate conventions (e.g. AdUnit.fpd.user.data.segments). I recognize this might require working with bid adapters to make sure they're reading from the standard FPD locations.
Immediate changes before we merge this docs PR
- move the segmentMap and segmentCache parameters under a params block
- make it more clear who needs to do what, and if a publisher is supposed to do this, why not provide them with the logic needed for adapters that currently support segments? Making them dig this up is unfriendly.
- provide contact info for how to sign up for your service.
We can address the other items (like getting rid of the bidSegmentMapper) in future phases.
@bretg please see changes in prebid/Prebid.js#5903, they should address most issues presented here. I've also updated the docs here and in Prebid.js. |
@bretg as discussed, updated the docs and submitted an update to the PR at prebid/Prebid.js#5903. |
|
||
Compile the audigent RTD module into your Prebid build: | ||
|
||
`gulp build --modules=userId,unifiedIdSystem,rtdModule,audigentRtdProvider,appnexusBidAdapter` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
technically you don't need to specify either userId
or rtdModule
here -- they should be included by the sub-modules that require them.
part of 4.17 |
* add audigent rtd provider docs * update audigent rtd provider docs * remove section * doc update * update audigent docs * update docs * update audigent docs * add parameter description dtable * fix name * add default specification * documentation update * requestParams object type * header size in markdown * brand halo module * formatting
This PR adds the documentation for the Audigent RTD module. Relevant PRs
prebid/Prebid.js#4834
prebid/Prebid.js#5777