Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Audigent RTD provider Docs #2369

Merged
merged 16 commits into from
Nov 19, 2020
Merged

Add Audigent RTD provider Docs #2369

merged 16 commits into from
Nov 19, 2020

Conversation

antlauzon
Copy link
Contributor

This PR adds the documentation for the Audigent RTD module. Relevant PRs

prebid/Prebid.js#4834
prebid/Prebid.js#5777

dev-docs/modules/audigentRtdProvider.md Outdated Show resolved Hide resolved
dev-docs/modules/audigentRtdProvider.md Outdated Show resolved Hide resolved
dev-docs/modules/audigentRtdProvider.md Outdated Show resolved Hide resolved
@antlauzon
Copy link
Contributor Author

@bretg thanks for the feedback, addressing these issues

@antlauzon
Copy link
Contributor Author

@bretg we're going to extend our RTD module to modify bid requests for individual bid adapters generically so that individual bid adapters do not require modification. i'm going to submit another PR to Prebid main and update the docs here once that is completed.

@antlauzon
Copy link
Contributor Author

Updated Prebid.js PR prebid/Prebid.js#5903

Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm understanding it correctly, this module is supplying First Party Data without using the appropriate FPD conventions.

I dislike the "bidSegmentMappers" design here -- first publishers shouldn't have to do this and secondly, it's perpetuating bidder-specific FPD.

I'm willing to let this happen for a transition period, but expect to see it evolve to use the appropriate conventions (e.g. AdUnit.fpd.user.data.segments). I recognize this might require working with bid adapters to make sure they're reading from the standard FPD locations.

Immediate changes before we merge this docs PR

  1. move the segmentMap and segmentCache parameters under a params block
  2. make it more clear who needs to do what, and if a publisher is supposed to do this, why not provide them with the logic needed for adapters that currently support segments? Making them dig this up is unfriendly.
  3. provide contact info for how to sign up for your service.

We can address the other items (like getting rid of the bidSegmentMapper) in future phases.

dev-docs/modules/audigentRtdProvider.md Outdated Show resolved Hide resolved
dev-docs/modules/audigentRtdProvider.md Outdated Show resolved Hide resolved
dev-docs/modules/audigentRtdProvider.md Outdated Show resolved Hide resolved
@antlauzon
Copy link
Contributor Author

@bretg please see changes in prebid/Prebid.js#5903, they should address most issues presented here. I've also updated the docs here and in Prebid.js.

dev-docs/modules/audigentRtdProvider.md Outdated Show resolved Hide resolved
dev-docs/modules/audigentRtdProvider.md Outdated Show resolved Hide resolved
@antlauzon
Copy link
Contributor Author

@bretg as discussed, updated the docs and submitted an update to the PR at prebid/Prebid.js#5903.

@antlauzon antlauzon requested a review from bretg November 3, 2020 00:18

Compile the audigent RTD module into your Prebid build:

`gulp build --modules=userId,unifiedIdSystem,rtdModule,audigentRtdProvider,appnexusBidAdapter`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically you don't need to specify either userId or rtdModule here -- they should be included by the sub-modules that require them.

@bretg bretg added LGTM and removed needs work labels Nov 3, 2020
@bretg
Copy link
Contributor

bretg commented Nov 19, 2020

part of 4.17

@bretg bretg merged commit 5feeb2e into prebid:master Nov 19, 2020
osazos pushed a commit to onfocusio/prebid.github.io that referenced this pull request Jan 21, 2021
* add audigent rtd provider docs

* update audigent rtd provider docs

* remove section

* doc update

* update audigent docs

* update docs

* update audigent docs

* add parameter description dtable

* fix name

* add default specification

* documentation update

* requestParams object type

* header size in markdown

* brand halo module

* formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants