Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for Geoedge Rtd provider #2474

Merged
merged 4 commits into from
Dec 3, 2020
Merged

Add docs for Geoedge Rtd provider #2474

merged 4 commits into from
Dec 3, 2020

Conversation

GeoEdge-r-and-d
Copy link
Contributor

This PR adds publisher docs for Geoedge RTD provider. Relevant Prebid.js PR: #5689

@GeoEdge-r-and-d GeoEdge-r-and-d mentioned this pull request Nov 5, 2020
Merged
@bretg
Copy link
Contributor

bretg commented Nov 5, 2020

This looks fine, though I suspect we're going to need to add a "loads external code" disclosure. We'll work that out in the code PR.

@bretg bretg self-requested a review November 5, 2020 18:10
@bretg bretg self-assigned this Nov 5, 2020
@jeanstemp jeanstemp merged commit 4238e1c into prebid:master Dec 3, 2020
osazos pushed a commit to onfocusio/prebid.github.io that referenced this pull request Jan 21, 2021
@GeoEdge-r-and-d @mmndaniel
@bretg @osazos
Add docs for Geoedge Rtd provider (prebid#2474)
c67cd03 
* Add docs for Geoedge Rtd provider

* fixed a couple of typos

* Added external code disclosure

* Update geoedgeRtdProvider.md

Co-authored-by: daniel manan <mmndaniel@gmail.com>
Co-authored-by: bretg <bgorsline@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bretg bretg bretg approved these changes

Assignees

@bretg bretg

Labels
LGTM Pending PBJS Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GeoEdge-r-and-d @bretg @jeanstemp @mmndaniel