Native phase 2 #2479
Merged
Native phase 2 #2479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 6, 2020
jeanstemp
approved these changes
Nov 13, 2020
allanjun
reviewed
Nov 16, 2020
jsnellbaker
reviewed
Jan 13, 2021
Comment on lines
+82
to
+100
| ``` | ||
| <div class="sponsored-post"> | ||
| <div class="thumbnail" style="background-image: url(##hb_native_image##);"></div> | ||
| <div class="content"> | ||
| <h1><a href="%%CLICK_URL_UNESC%%##hb_native_linkurl##" target="_blank" class="pb-click">##hb_native_title##</a></h1> | ||
| <p>##hb_native_body##</p> | ||
| <div class="attribution">##hb_native_brand##</div> | ||
| </div> | ||
| </div> | ||
| <script src="https://cdn.jsdelivr.net/npm/prebid-universal-creative@latest/dist/native-render.js"></script> | ||
| <script> | ||
| var pbNativeTagData = {}; | ||
| pbNativeTagData.pubUrl = "%%PATTERN:url%%"; | ||
| pbNativeTagData.adId = "%%PATTERN:hb_adid%%"; | ||
| // if you're using 'Send All Bids' mode, you should use %%PATTERN:hb_adid_BIDDER%% | ||
| pbNativeTagData.requestAllAssets = true; | ||
| window.pbNativeTag.renderNativeAd(pbNativeTagData); | ||
| </script> | ||
| ``` |
There was a problem hiding this comment.
Hi @bretg
When I was looking at this page on the local build, it seems the formatting around this code block isn't working as expected which affected the following code/formatting down to the next major heading. I attached a screenshot for reference:
Could you take a look?
There was a problem hiding this comment.
@jsnellbaker - I don't see this mis-formatting on my local Jekyll. And the markdown looks ok. Am going to go ahead and merge, will check the site and fix if needed.
osazos
pushed a commit
to onfocusio/prebid.github.io
that referenced
this pull request
Jan 21, 2021
* pbjs native 2.0 initial commit * first cut at GAM-Native * wordsmithing * chased down other native references * minor edits * review updates Co-authored-by: Jean Stemp <jstemp@appnexus.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation for PBJS PR prebid/Prebid.js#5411 and PUC PR prebid/prebid-universal-creative#106