Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create houseofpubs.md bidder instructions #2568

Merged
merged 3 commits into from
Jan 13, 2021
Merged

Conversation

iskmerof
Copy link
Contributor

Adding on behalf of a client alias

Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see pull requests for either PBJS or PBS. Please create PRs and paste this link in both.

@bretg
Copy link
Contributor

bretg commented Dec 14, 2020

Please remove the "pbs: true" header. Prebid Server doesn't currently support hard-coded aliases. Please remove the "pbs: true" header field for now. You can instruct your customers to use "soft" aliases.

pbjs.setConfig({
   s2sConfig: {
      ...
      extPrebid: {
          aliases: {
                houseofpubs: adkernel
            }
      }
   }
});

Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the pbs:true flag for you. Please instruct your customers to use a soft alias as noted above.

@bretg bretg added LGTM and removed needs work labels Jan 13, 2021
@bretg bretg merged commit 3a35982 into prebid:master Jan 13, 2021
osazos pushed a commit to onfocusio/prebid.github.io that referenced this pull request Jan 21, 2021
* Create houseofpubs.md bidder instructions

Adding on behalf of a client alias

* removing stray period

* removing PBS flag

Co-authored-by: bretg <bgorsline@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants