Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update references to PubCommon to SharedId #2904

Merged
merged 7 commits into from
Jun 21, 2021
Merged

Conversation

jdwieland8282
Copy link
Member

renaming references to PubCommon to SharedId
removing references to the original SharedId module

renaming references to PubCommon to SharedId
removing references to the original SharedId module
renaming reference to Pubcommon Id, removing original reference to Sharedid
fixing outdated source = value for "pubcommon" to "pubcid.org"
renaming reference to pubcommonId to sharedid, removing original reference to Sharedid
@bretg
Copy link
Contributor

bretg commented Apr 26, 2021

The plan is to support both pubCommonId and sharedId as names for the module. I think from the documentation perspective we should suggest that new implementations use sharedId, but add a note that pubCommonId is supported for backwards compatibility.

adding note for sharedid formally known as PC.
renaming pubcommonidsystem to sharedIdSystem
@jeanstemp jeanstemp added the LGTM label May 21, 2021
@bretg bretg merged commit daf5473 into master Jun 21, 2021
@bretg bretg deleted the jdwieland8282-patch-10 branch June 21, 2021 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants