-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update references to PubCommon to SharedId #2904
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renaming references to PubCommon to SharedId removing references to the original SharedId module
renaming reference to Pubcommon Id, removing original reference to Sharedid
fixing outdated source = value for "pubcommon" to "pubcid.org"
renaming reference to pubcommonId to sharedid, removing original reference to Sharedid
jdwieland8282
changed the title
Update userId.md
Update references to PubCommon to SharedId
Apr 26, 2021
The plan is to support both pubCommonId and sharedId as names for the module. I think from the documentation perspective we should suggest that new implementations use sharedId, but add a note that pubCommonId is supported for backwards compatibility. |
adding note for sharedid formally known as PC.
renaming pubcommonidsystem to sharedIdSystem
jeanstemp
reviewed
Apr 29, 2021
jeanstemp
approved these changes
May 21, 2021
gmcgrath11
approved these changes
Jun 1, 2021
bretg
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
renaming references to PubCommon to SharedId
removing references to the original SharedId module