Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dev-docs with floc #3006

Merged
merged 4 commits into from
Jun 7, 2021
Merged

Update dev-docs with floc #3006

merged 4 commits into from
Jun 7, 2021

Conversation

jdwieland8282
Copy link
Member

Adding documentation for the FLoC user id module.

Adding documentation for the FLoC user id module.
Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a few tweaks.

Copy link
Collaborator

@smenzer smenzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

should the full sharedId token be shared in the docs someplace, though?

@patmmccann
Copy link
Collaborator

patmmccann commented Jun 4, 2021 via email

@bretg
Copy link
Contributor

bretg commented Jun 4, 2021

should the full sharedId token be shared in the docs someplace, though?

Oh - I truncated the token because it blew out the table to the point where it was very awkward.

Take another look? Had to play around with getting that long of a string to appear without blowing out the page.

Copy link
Collaborator

@smenzer smenzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @bretg

@bretg bretg merged commit 5daab99 into master Jun 7, 2021
@bretg bretg deleted the jdwieland8282-patch-11 branch June 7, 2021 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants