Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BeOp bidder documentation #3238

Merged
merged 1 commit into from
Sep 2, 2021
Merged

Add BeOp bidder documentation #3238

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions dev-docs/bidders/beop.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
---
layout: bidder
title: BeOp
description: BeOp Bidder Adaptor
pbjs: true
biddercode: beop
---

### Bid Params

{: .table .table-bordered .table-striped }
| Name | Scope | Description | Example | Type |
|---------------|----------|-------------|---------|----------|
| `accountId` or `networkId` | required | Your BeOp account ID | `'5a8af500c9e77c00017e4cad'` | `string` |
| `currency` | optional | Your currency | `'EUR'` (default) or `'USD'` | `string` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record you should be primarily asking the publisher for their currency as a bidder-specific param. See the Currency module for the standard location for pubs to define their currency.

Instead of

  const publisherCurrency = utils.getValue(bid.params, 'currency') || 'EUR';

You should be doing something like this:

  const publisherCurrency = config.getConfig('currency.adServerCurrency') || utils.getValue(bid.params, 'currency') || 'EUR';

First look in the standard location, then it's ok to have a bidder-specific fall back param and an overall default.

Since your adapter has already been released, I'll go ahead and merge these docs, but am going to open a PBJS issue to track this resolution.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll create a PR right away