Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yieldlab Adapter: add iab content docs #3267

Merged
merged 6 commits into from
Oct 29, 2021

Conversation

rey1128
Copy link
Contributor

@rey1128 rey1128 commented Sep 14, 2021

add docs of iabContent object

@patmmccann
Copy link
Collaborator

patmmccann commented Sep 15, 2021

Hi @rey1128 Can you add an example to https://github.com/prebid/prebid.github.io/blob/master/features/firstPartyData.md of someone setting the Content object via setConfig on ortb2?

Thanks!

@netlify
Copy link

netlify bot commented Sep 15, 2021

✔️ Deploy Preview for jovial-darwin-d953d9 ready!

🔨 Explore the source changes: 216caa9

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-darwin-d953d9/deploys/61423964d9f3090008733f1c

😎 Browse the preview: https://deploy-preview-3267--jovial-darwin-d953d9.netlify.app

@rey1128
Copy link
Contributor Author

rey1128 commented Sep 15, 2021

hi @patmmccann
i've added an example in the fpd page, could you have another look?

thanks

Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you give 'bretg' edit rights on your fork, I'd tweak the english a little bit here, otherwise, I'll fix it up after merging.

@rey1128
Copy link
Contributor Author

rey1128 commented Oct 13, 2021

hello there, as the related pull request is merged, could you take another look about this pr?
thanks a lot

@ChrisHuie
Copy link
Contributor

@rey1128 merging :) Sorry about the delay

@ChrisHuie ChrisHuie merged commit 5247ce2 into prebid:master Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants