Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snowflake ID is now Hyper ID and document new SharedID changes #3542

Merged
merged 9 commits into from
Feb 2, 2022

Conversation

rajsidhunovatiq
Copy link
Contributor

Marketing change + instructions on how to use the new sharedID functionality with this module.

novatiq and others added 6 commits February 24, 2021 11:33
Included novatiq snowflake id submodule specifications
Added novatiq snowflake id submodule
This reverts commit 556d56a.
Novatiq ID System: updated product description as per request
…nto merge_latest

# Conflicts:
#	dev-docs/modules/userId.md
#	download.md
@netlify
Copy link

netlify bot commented Feb 1, 2022

✔️ Deploy Preview for prebid-docs-preview ready!

🔨 Explore the source changes: cc44816

🔍 Inspect the deploy log: https://app.netlify.com/sites/prebid-docs-preview/deploys/61f9a4beb8e58b000787c409

😎 Browse the preview: https://deploy-preview-3542--prebid-docs-preview.netlify.app/dev-docs/modules/userid

MartianTribe
MartianTribe previously approved these changes Feb 1, 2022
@MartianTribe MartianTribe dismissed their stale review February 1, 2022 19:22

I noticed some errors after I approved this.

@MartianTribe
Copy link
Collaborator

MartianTribe commented Feb 1, 2022

When I looked at the doc in the netlify preview the tables were all broken. If you click on the details of the last check:

netlify/prebid-docs-preview/deploy-preview

It will launch a preview of the docs site. If you then go to your submission, you'll see all the tables are displayed incorrectly:

/dev-docs/modules/userid#novatiq-hyper-id

In the same preview, mediawallah, the ID up from yours with a table, displays ok:

/dev-docs/modules/userid#mediawallah-openlinkid

try doing like they did and wrap it in the table div:

<div class="table-responsive" markdown="1">
| Param under userSync.userIds[] | Scope | Type | Description | Example |
| --- | --- | --- | --- | --- |
| name | Required | String | The name of this module. | `'mwOpenLinkId'` |
| params | Required | Object | Details for mwOLID syncing. ||
| params.accountId | Required | String | The MediaWallah assigned Account Id  | `1000` |
| params.partnerId | Required | String | The MediaWallah assign partner Id |`'1001'`|
| params.uid | Optional | String | Your unique Id for the user or browser. Used for matching. | `'u-123xyz'` |
{: .table .table-bordered .table-striped }
</div>

@rajsidhunovatiq
Copy link
Contributor Author

fixed layout and format as per other examples, thank you.

Copy link
Collaborator

@MartianTribe MartianTribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tables look good. Thanks for the quick fix.

@MartianTribe MartianTribe merged commit 17f3826 into prebid:master Feb 2, 2022
jlaso pushed a commit to AuDigent/prebid.github.io that referenced this pull request Nov 6, 2024
…d#3542)

* Update userId.md

Included novatiq snowflake id submodule specifications

* Update download.md

Added novatiq snowflake id submodule

* Revert "Update userId.md"

This reverts commit 556d56a.

* Update userId.md

Novatiq ID System: updated product description as per request

* fix layout and format as per other examples

* tables still broken, missed markup line just before the close div - try again

* whitespace?

Co-authored-by: novatiq <79258366+novatiq@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants