-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snowflake ID is now Hyper ID and document new SharedID changes #3542
Conversation
Included novatiq snowflake id submodule specifications
Added novatiq snowflake id submodule
This reverts commit 556d56a.
Novatiq ID System: updated product description as per request
…nto merge_latest # Conflicts: # dev-docs/modules/userId.md # download.md
Merge latest
✔️ Deploy Preview for prebid-docs-preview ready! 🔨 Explore the source changes: cc44816 🔍 Inspect the deploy log: https://app.netlify.com/sites/prebid-docs-preview/deploys/61f9a4beb8e58b000787c409 😎 Browse the preview: https://deploy-preview-3542--prebid-docs-preview.netlify.app/dev-docs/modules/userid |
I noticed some errors after I approved this.
When I looked at the doc in the netlify preview the tables were all broken. If you click on the details of the last check: netlify/prebid-docs-preview/deploy-preview It will launch a preview of the docs site. If you then go to your submission, you'll see all the tables are displayed incorrectly: /dev-docs/modules/userid#novatiq-hyper-id In the same preview, mediawallah, the ID up from yours with a table, displays ok: /dev-docs/modules/userid#mediawallah-openlinkid try doing like they did and wrap it in the table div:
|
fixed layout and format as per other examples, thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tables look good. Thanks for the quick fix.
…d#3542) * Update userId.md Included novatiq snowflake id submodule specifications * Update download.md Added novatiq snowflake id submodule * Revert "Update userId.md" This reverts commit 556d56a. * Update userId.md Novatiq ID System: updated product description as per request * fix layout and format as per other examples * tables still broken, missed markup line just before the close div - try again * whitespace? Co-authored-by: novatiq <79258366+novatiq@users.noreply.github.com>
Marketing change + instructions on how to use the new sharedID functionality with this module.