Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Viously Bid Adapter : New Adapter #4058

Merged
merged 4 commits into from
Jan 10, 2023
Merged

Viously Bid Adapter : New Adapter #4058

merged 4 commits into from
Jan 10, 2023

Conversation

geoffray-viously
Copy link
Contributor

@geoffray-viously geoffray-viously commented Oct 5, 2022 •
edited
Loading

🏷 Type of documentation

  • new bid adapter

📋 Checklist

PR in Prebid.js : prebid/Prebid.js#9076

@netlify
Copy link

netlify bot commented Oct 5, 2022 •
edited
Loading

✅ Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit 9628fe3
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/63402ddb9b348a00095b61d1
😎 Deploy Preview https://deploy-preview-4058--prebid-docs-preview.netlify.app/dev-docs/bidders/viously
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@geoffray-viously geoffray-viously mentioned this pull request Oct 5, 2022
Merged
1 task
bretg
bretg requested changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the

dev-docs/bidders/viously.md Outdated
title: Viously
description: Prebid Viously Bidder Adaptor
pbjs: true
pbs: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a code PR supporting Prebid Server. Please set this to false. Also, you're missing some other metadata fields like multiformat_supported, ortb_blocking_supported, dchain, etc. Please check https://docs.prebid.org/dev-docs/bidder-adaptor.html#submitting-your-adapter

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the reply.
I've updated and added the missing parameters.

Geoffray

@jeanstemp
Copy link
Contributor

@geoffray-viously, can you add one more line to the metadata in the header? We updated the navigation and all bidder docs now need to include sidebarType: 1 with the header data.
cc @bretg

@geoffray-viously
Copy link
Contributor Author

@geoffray-viously, can you add one more line to the metadata in the header? We updated the navigation and all bidder docs now need to include sidebarType: 1 with the header data. cc @bretg

Hello,

it is done
@bretg

Geoffray

@ChrisHuie ChrisHuie merged commit da91f49 into prebid:master Jan 10, 2023
@geoffray-viously geoffray-viously deleted the add-viously-bidadapter branch June 7, 2023 12:22
ecdrsvc pushed a commit to ecdrsvc/prebid.github.io that referenced this pull request Sep 6, 2023
@geoffray-viously @ecdrsvc
Viously Bid Adapter : New Adapter (prebid#4058)
2a487b9 
* Add: viously.md for Viously Bid Adapter

* Update viously bidder documentation

* Add: video parameters

* Update the header
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bretg bretg bretg approved these changes

@fowler446 fowler446 fowler446 approved these changes

Assignees
No one assigned
Labels
LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@geoffray-viously @jeanstemp @fowler446 @bretg @ChrisHuie