Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AAX Adapter: Added medianet alias code #4116

Merged
merged 1 commit into from
Nov 17, 2022

Conversation

product-aax
Copy link
Contributor

🏷 Type of documentation

  • update bid adapter

📋 Checklist

@netlify
Copy link

netlify bot commented Oct 28, 2022

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit ee296e0
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/635bb5c740698500087737ba
😎 Deploy Preview https://deploy-preview-4116--prebid-docs-preview.netlify.app/download
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@muuki88
Copy link
Contributor

muuki88 commented Oct 31, 2022

I only found the linked pull request ( #4116 ), which indicates that aax was added as an alias to medianet. Not the other way round.

@product-aax
Copy link
Contributor Author

Our intention is to add aax as an alias to medianet. Can you please let us know where you see this the other way around?
And can you direct us to specific changes that you want us to do, to avoid any confusion?

@muuki88
Copy link
Contributor

muuki88 commented Nov 1, 2022

See the linked PR from Prebid.js above 😊

@product-aax
Copy link
Contributor Author

We are following this doc: https://docs.prebid.org/dev-docs/bidder-adaptor.html.
Under the 'submitting your Adapter' heading, it says the following:
Add ‘aliasCode’ if your biddercode is not the same name as your PBJS implementation file. e.g. if your biddercode is “ex”, but the file in the PBJS repo is exampleBidAdapter.js, this value needs to be “example”.

Our BidderCode (aax) is not the same name as our PBJS implementation file. Our PBJS implementation file name is medianetBidAdapter. Hence we have added aliasCode: MediaNet

Are we missing something here?

@product-aax
Copy link
Contributor Author

Sharing an example of an existing setup

pagescience is a alias of appnexus as shown here and here pagescience has declared 'aliasCode : appnexus '

Likewise, aax is an alias of medianet as shown here and here aax has declared 'aliasCode : medianet '

@product-aax
Copy link
Contributor Author

@muuki88 can you please have a look.

@muuki88 muuki88 added LGTM and removed needs work labels Nov 17, 2022
@muuki88 muuki88 merged commit 19a427d into prebid:master Nov 17, 2022
@muuki88
Copy link
Contributor

muuki88 commented Nov 17, 2022

Thanks for the research work ❤️

ecdrsvc pushed a commit to ecdrsvc/prebid.github.io that referenced this pull request Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants