Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding server response examples #414

Merged
merged 2 commits into from
Oct 24, 2017
Merged

Adding server response examples #414

merged 2 commits into from
Oct 24, 2017

Conversation

dbemiller
Copy link
Contributor

Documenting the changes from prebid/Prebid.js#1748

Copy link
Collaborator

@matthewlane matthewlane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, found a typo unrelated, but geographically close to the changes here, noted below

@@ -233,6 +233,10 @@ The `interpretResponse` function will be called when the browser has received th
// if the bid response was empty or an error, return []
// otherwise parse the response and return a bidReponses array
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed this bidReponses typo, mind sneaking a fix into this PR?

@mkendall07 mkendall07 merged commit abd8c28 into prebid:master Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants